Skip to content

examples: fix -Wshadow warnings

Stephen Hemminger dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest23 patches 6 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23examples/ethtool: resolve shadow variable warningsexamples/ethtool/ethtool-app/main.c examples/ethtool/meson.build+2 -31 reply
2/23examples/eventdev_pipeline: resolve shadow variable warningexamples/eventdev_pipeline/meson.build examples/eventdev_pipeline/pipeline_worker_tx.c+2 -30 replies
3/23examples/dma: resolve shadow variable warningsexamples/dma/dmafwd.c examples/dma/meson.build+5 -61 reply
4/23examples/packet_ordering: resolve shadow variable warningexamples/packet_ordering/main.c examples/packet_ordering/meson.build+3 -40 replies
5/23examples/bond: resolve shadow variable warningsexamples/bond/main.c examples/bond/meson.build+10 -120 replies
6/23examples/vmdq: resolve shadow variable warningexamples/vmdq/main.c examples/vmdq/meson.build+4 -50 replies
7/23examples/server_node_efd: resolve shadow variable warningexamples/server_node_efd/efd_server/args.c examples/server_node_efd/efd_server/meson.build+3 -40 replies
8/23examples/flow_filtering: resolve shadowed variable warningsexamples/flow_filtering/flow_skeleton.c examples/flow_filtering/main.c examples/flow_filtering/meson.build+7 -80 replies
9/23examples/ipsec-secgw: resolve shadowed variable warningsexamples/ipsec-secgw/ipsec-secgw.c examples/ipsec-secgw/ipsec.c examples/ipsec-secgw/ipsec.h +4 more+41 -492 replies
10/23examples/ip_pipeline: resolve shadow variable warningexamples/ip_pipeline/cli.c examples/ip_pipeline/meson.build+4 -60 replies
11/23examples/multi_process: resolve shadowed variable warningsexamples/multi_process/client_server_mp/mp_server/args.c examples/multi_process/client_server_mp/mp_server/meson.build+6 -70 replies
12/23examples/vm_power_manage: enable shadow warningsexamples/vm_power_manager/guest_cli/meson.build examples/vm_power_manager/meson.build+0 -21 reply
13/23examples/bbdev_app: enable shadow warningsexamples/bbdev_app/main.c examples/bbdev_app/meson.build+1 -40 replies
14/23examples/ptpclient: resolve shadow variable warningsexamples/ptpclient/meson.build examples/ptpclient/ptpclient.c+69 -700 replies
15/23examples/vhost: resolve shadow warningsexamples/vhost/main.c examples/vhost/meson.build+10 -100 replies
16/23examples/qos_sched: eliminate shadowed variablesexamples/qos_sched/cfg_file.c examples/qos_sched/cfg_file.h examples/qos_sched/init.c +1 more+10 -110 replies
17/23examples/l2fwd-jobstats: resolve shadowed variableexamples/l2fwd-jobstats/main.c examples/l2fwd-jobstats/meson.build+3 -40 replies
18/23examples/l2fwd-crypto: resolve shadow variableexamples/l2fwd-crypto/main.c examples/l2fwd-crypto/meson.build+25 -260 replies
19/23examples/l2fwd-event: resolve shadowed variableexamples/l2fwd-event/main.c examples/l2fwd-event/meson.build+7 -90 replies
20/23examples/l2fwd-keepalive: resolve shadow variable warningexamples/l2fwd-keepalive/main.c examples/l2fwd-keepalive/meson.build+1 -20 replies
21/23examples/l3fwd-graph: resolve shadow variable warningexamples/l3fwd-graph/main.c examples/l3fwd-graph/meson.build+4 -50 replies
22/23examples/l3fwd: resolve shadow variable warningsexamples/l3fwd/l3fwd.h examples/l3fwd/l3fwd_em.c examples/l3fwd/l3fwd_em_hlm.h +4 more+65 -620 replies
23/23examples/l3fwd-power: resolve shadow variable warningsexamples/l3fwd-power/main.c examples/l3fwd-power/meson.build+6 -70 replies

Reviews trailers per patch

All 23 patches have a Reviewed-by or Acked-by.

PatchBruce RichardsonChengwen FengRadu Nicolau
1/23A-b A-b
2/23A-b
3/23A-b A-b
4/23A-b
5/23A-b
6/23A-b
7/23A-b
8/23A-b
9/23A-b A-b
10/23A-b
11/23A-b
12/23A-b
13/23A-b
14/23A-b
15/23A-b
16/23A-b
17/23A-b
18/23A-b
19/23A-b
20/23A-b
21/23A-b
22/23A-b
23/23A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/23] examples: fix -Wshadow warnings

Several DPDK examples had -Wshadow disabled via no_shadow_cflag in their meson.build files. This series fixes all shadow variable warnings and removes the suppression flag, so that -Wshadow is enabled uniformly across every example.

The fixes fall into three categories:
- Renaming function parameters or local variables that shadow globals (most patches)
- Removing unused function parameters that duplicated globals (dma, bond, flow_filtering, ipsec-secgw, vhost, qos_sched)
- Simply removing no_shadow_cflag where there were no warnings (vm_power_manage, bbdev_app, l2fwd-crypto, l2fwd-event, l3fwd-graph)

v2 - fix additional shadow warnings only visible with clang

Stephen Hemminger (23):
examples/ethtool: resolve shadow variable warnings examples/eventdev_pipeline: resolve shadow variable warning examples/dma: resolve shadow variable warnings examples/packet_ordering: resolve shadow variable warning examples/bond: resolve shadow variable warnings examples/vmdq: resolve shadow variable warning examples/server_node_efd: resolve shadow variable warning examples/flow_filtering: resolve shadowed variable warnings examples/ipsec-secgw: resolve shadowed variable warnings examples/ip_pipeline: resolve shadow variable warning examples/multi_process: resolve shadowed variable warnings examples/vm_power_manage: enable shadow warnings examples/bbdev_app: enable shadow warnings examples/ptpclient: resolve shadow variable warnings examples/vhost: resolve shadow warnings examples/qos_sched: eliminate shadowed variables examples/l2fwd-jobstats: resolve shadowed variable examples/l2fwd-crypto: resolve shadow variable examples/l2fwd-event: resolve shadowed variable examples/l2fwd-keepalive: resolve shadow variable warning examples/l3fwd-graph: resolve shadow variable warning examples/l3fwd: resolve shadow variable warnings examples/l3fwd-power: resolve shadow variable warnings

 examples/bbdev_app/main.c                     |   4 +-
 examples/bbdev_app/meson.build                |   1 -
 examples/bond/main.c                          |  21 ++-
 examples/bond/meson.build                     |   1 -
 examples/dma/dmafwd.c                         |  10 +-
 examples/dma/meson.build                      |   1 -
 examples/ethtool/ethtool-app/main.c           |   4 +-
 examples/ethtool/meson.build                  |   1 -
 examples/eventdev_pipeline/meson.build        |   1 -
 .../eventdev_pipeline/pipeline_worker_tx.c    |   4 +-
 examples/flow_filtering/flow_skeleton.c       |  10 +-
 examples/flow_filtering/main.c                |   4 +-
 examples/flow_filtering/meson.build           |   1 -
 examples/ip_pipeline/cli.c                    |   9 +-
 examples/ip_pipeline/meson.build              |   1 -
 examples/ipsec-secgw/ipsec-secgw.c            |  17 +--
 examples/ipsec-secgw/ipsec.c                  |   3 +-
 examples/ipsec-secgw/ipsec.h                  |   1 -
 examples/ipsec-secgw/ipsec_worker.c           |  30 ++--
 examples/ipsec-secgw/ipsec_worker.h           |   4 +-
 examples/ipsec-secgw/meson.build              |   1 -
 examples/ipsec-secgw/sa.c                     |  34 ++---
 examples/l2fwd-crypto/main.c                  |  50 +++----
 examples/l2fwd-crypto/meson.build             |   1 -
 examples/l2fwd-event/main.c                   |  15 +-
 examples/l2fwd-event/meson.build              |   1 -
 examples/l2fwd-jobstats/main.c                |   6 +-
 examples/l2fwd-jobstats/meson.build           |   1 -
 examples/l2fwd-keepalive/main.c               |   2 +-
 examples/l2fwd-keepalive/meson.build          |   1 -
 examples/l3fwd-graph/main.c                   |   8 +-
 examples/l3fwd-graph/meson.build              |   1 -
 examples/l3fwd-power/main.c                   |  12 +-
 examples/l3fwd-power/meson.build              |   1 -
 examples/l3fwd/l3fwd.h                        |   2 +-
 examples/l3fwd/l3fwd_em.c                     |  32 ++--
 examples/l3fwd/l3fwd_em_hlm.h                 |   8 +-
 examples/l3fwd/l3fwd_lpm.c                    |   4 +-
 examples/l3fwd/l3fwd_route.h                  |  12 +-
 examples/l3fwd/main.c                         |  68 ++++-----
 examples/l3fwd/meson.build                    |   1 -
 .../client_server_mp/mp_server/args.c         |  12 +-
 .../client_server_mp/mp_server/meson.build    |   1 -
 examples/packet_ordering/main.c               |   6 +-
 examples/packet_ordering/meson.build          |   1 -
 examples/ptpclient/meson.build                |   1 -
 examples/ptpclient/ptpclient.c                | 138 +++++++++---------
 examples/qos_sched/cfg_file.c                 |  12 +-
 examples/qos_sched/cfg_file.h                 |   4 +-
 examples/qos_sched/init.c                     |   4 +-
 examples/qos_sched/meson.build                |   1 -
 examples/server_node_efd/efd_server/args.c    |   6 +-
 .../server_node_efd/efd_server/meson.build    |   1 -
 examples/vhost/main.c                         |  19 +--
 examples/vhost/meson.build                    |   1 -
 .../vm_power_manager/guest_cli/meson.build    |   1 -
 examples/vm_power_manager/meson.build         |   1 -
 examples/vmdq/main.c                          |   8 +-
 examples/vmdq/meson.build                     |   1 -
 59 files changed, 288 insertions(+), 319 deletions(-)
Signature · 1 line
2.53.0