Skip to content

Cleanups and fixes

Arnaldo Carvalho de Melo linux-perf-users lkml 3 versions – Applied

Status from this message: Applied to perf-tools-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest8 patches 3 repliesApplied
  2. v50 of 7 patches 0 repliesSuperseded
  3. v46 patches 2 repliesSuperseded

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/8perf symbols: Make variable receiving result strrchr() consttools/perf/util/symbol.c+1 -10 replies
2/8perf util: Kill die() prototype, dead for a long timetools/perf/util/util.h+0 -10 replies
3/8perf tools: Make more global variables statictools/perf/arch/common.c tools/perf/arch/sh/include/dwarf-regs-table.h tools/perf/bench/breakpoint.c +21 more+109 -1120 replies
4/8perf bench: Constify tablestools/perf/builtin-bench.c+21 -210 replies
5/8perf header: Use a max number of command line argstools/perf/util/header.c+6 -00 replies
6/8perf header: Do validation of perf.data HEADER_CPU_DOMAIN_INFOtools/perf/util/header.c+11 -00 replies
7/8perf tools: Use calloc() where applicabletools/perf/arch/arm/util/auxtrace.c tools/perf/arch/powerpc/util/auxtrace.c tools/perf/arch/x86/tests/amd-ibs-period.c +39 more+72 -930 replies
8/8perf tools: Replace basename() calls with perf_basename()tools/perf/builtin-daemon.c tools/perf/util/annotate.c tools/perf/util/data-convert-json.c +6 more+31 -520 replies

Reviews trailers per patch

2 of 8 patches have a Reviewed-by or Acked-by.

PatchIan RogersAnkur AroraNamhyung Kim
1/8
2/8R-b
3/8A-b A-b
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCHES perf-tools-next v6 0/8] Cleanups and fixes

Hi,

Here are some cleanups, a refresh for a patch Ian sent and fell
thru the cracks, using calloc where applicable, constify some arrays and add a missing header that was making the build fail on some musl systems.

This also adds checks for perf.data headers that were suggested
by sashiko.

Thanks a lot,

- Arnaldo

v6: thinko, fix subject of cover letter, its 0/8...

v5: Address more comments and add perf.data header checks.

v4: Address some more Sashiko comments, see patch comments for details.

v3: Address https://sashiko.dev review, removed a malloc->calloc conversion, flawed, and removed the changes to trace-event-scripting.c, that made the build fail in some situation, see the committer notes in the patch for more details.

v2: remove the commenting of gen_vmlinux in tools/perf/tests/make as noticed by Ian Rogers.

Arnaldo Carvalho de Melo (7):
perf symbols: Make variable receiving result strrchr() const perf util: Kill die() prototype, dead for a long time perf bench: Constify tables
perf header: Use a max number of command line args perf header: Do validation of perf.data HEADER_CPU_DOMAIN_INFO perf tools: Use calloc() where applicable
perf tools: Replace basename() calls with perf_basename()

Ian Rogers (1):
perf tools: Make more global variables static

 tools/perf/arch/arm/util/auxtrace.c           |   6 +-
 tools/perf/arch/common.c                      |  22 ++--
 tools/perf/arch/powerpc/util/auxtrace.c       |   1 +
 tools/perf/arch/sh/include/dwarf-regs-table.h |   2 +-
 tools/perf/arch/x86/tests/amd-ibs-period.c    |   3 +-
 tools/perf/arch/x86/tests/dwarf-unwind.c      |  11 +-
 tools/perf/arch/x86/util/pmu.c                |   1 -
 tools/perf/bench/breakpoint.c                 |   4 +-
 tools/perf/bench/mem-functions.c              |   2 +-
 tools/perf/bench/numa.c                       |  15 +--
 tools/perf/bench/sched-messaging.c            |   2 +-
 tools/perf/bench/uprobe.c                     |   2 +-
 tools/perf/builtin-annotate.c                 |   1 -
 tools/perf/builtin-bench.c                    |  42 +++----
 tools/perf/builtin-c2c.c                      |  13 ++-
 tools/perf/builtin-config.c                   |   2 +-
 tools/perf/builtin-daemon.c                   |   4 +-
 tools/perf/builtin-data.c                     |   8 +-
 tools/perf/builtin-diff.c                     |   6 +-
 tools/perf/builtin-ftrace.c                   |   1 +
 tools/perf/builtin-kmem.c                     |   2 +-
 tools/perf/builtin-kwork.c                    |  14 +--
 tools/perf/builtin-record.c                   |  10 +-
 tools/perf/builtin-sched.c                    |   6 +-
 tools/perf/builtin-script.c                   |  10 +-
 tools/perf/builtin-stat.c                     |   2 +-
 tools/perf/builtin-top.c                      |   5 +-
 tools/perf/builtin-trace.c                    |   4 +-
 tools/perf/jvmti/libjvmti.c                   |   5 +-
 tools/perf/tests/bp_signal.c                  |   2 +-
 tools/perf/tests/code-reading.c               |   1 +
 tools/perf/tests/dso-data.c                   |   2 +-
 tools/perf/tests/thread-map.c                 |   1 -
 tools/perf/tests/wp.c                         |   6 +-
 tools/perf/util/annotate-arch/annotate-x86.c  |   1 +
 tools/perf/util/annotate.c                    |   3 +-
 tools/perf/util/block-range.c                 |   2 +-
 tools/perf/util/bpf-event.c                   |   2 +-
 tools/perf/util/bpf_counter.c                 |   4 +-
 tools/perf/util/bpf_counter_cgroup.c          |   1 -
 tools/perf/util/bpf_off_cpu.c                 |   2 +-
 tools/perf/util/data-convert-bt.c             |   2 +-
 tools/perf/util/data-convert-json.c           |   4 +-
 tools/perf/util/data.c                        |   2 +-
 tools/perf/util/db-export.c                   |   1 -
 tools/perf/util/debug.c                       |   2 +-
 tools/perf/util/debuginfo.c                   |  19 ++--
 tools/perf/util/disasm.c                      |   1 +
 tools/perf/util/dsos.c                        |  32 ++----
 tools/perf/util/event.c                       |   1 -
 tools/perf/util/evlist.c                      |   3 +-
 tools/perf/util/header.c                      |  35 ++++--
 tools/perf/util/hist.c                        |   2 +-
 tools/perf/util/mem2node.c                    |   2 +-
 tools/perf/util/pmus.c                        |   2 +-
 tools/perf/util/powerpc-vpadtl.c              |   1 +
 tools/perf/util/probe-event.c                 |  20 ++--
 tools/perf/util/probe-file.c                  |   2 +-
 tools/perf/util/probe-finder.c                |   8 +-
 tools/perf/util/session.c                     |   2 +-
 tools/perf/util/sort.c                        | 104 +++++++++---------
 tools/perf/util/srcline.c                     |  12 +-
 tools/perf/util/stat-shadow.c                 |   1 -
 tools/perf/util/symbol.c                      |   2 +-
 tools/perf/util/symbol.h                      |  16 +--
 tools/perf/util/unwind-libunwind-local.c      |   1 -
 tools/perf/util/util.c                        |  10 +-
 tools/perf/util/util.h                        |   3 +-
 tools/perf/util/values.c                      |   8 +-
 69 files changed, 251 insertions(+), 280 deletions(-)
Signature · 1 line
2.53.0