Skip to content

ip_frag: TAILQ and hash fixes

Stephen Hemminger dpdk-dev 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2ip_frag: fix unsafe TAILQ usagelib/ip_frag/ip_frag_common.h lib/ip_frag/rte_ip_frag_common.c+11 -101 reply
2/2ip_frag: randomize hash seedlib/ip_frag/ip_frag_internal.c lib/ip_frag/ip_reassembly.h lib/ip_frag/rte_ip_frag_common.c+10 -101 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKonstantin Ananyev
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] ip_frag: TAILQ and hash fixes

The ip_frag library had a couple of issues found during review. The use of TAILQ made assumptions about TAILQ_REMOVE, and the hash function usage could be abused by attacker.

Stephen Hemminger (2):
ip_frag: fix unsafe TAILQ usage
ip_frag: randomize hash seed

 lib/ip_frag/ip_frag_common.h     |  1 +
 lib/ip_frag/ip_frag_internal.c   | 18 ++++++++----------
 lib/ip_frag/ip_reassembly.h      |  1 +
 lib/ip_frag/rte_ip_frag_common.c | 21 +++++++++++----------
 4 files changed, 21 insertions(+), 20 deletions(-)
Signature · 1 line
2.53.0