Skip to content

Never take root bo reservation locks with userq_mutex

Sunil Khatri amd-gfx 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 8 repliesIn review
  2. v24 patches 0 repliesSuperseded
  3. v14 patches 9 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/amdgpu/userq: caller to take reserv lock for vas_list_cleanupdrivers/gpu/drm/amd/amdgpu/amdgpu_userq.c+14 -121 reply
2/6drm/amdgpu/userq: hold root bo lock in caller of input_va_validatedrivers/gpu/drm/amd/amdgpu/amdgpu_userq.c drivers/gpu/drm/amd/amdgpu/mes_userqueue.c+32 -61 reply
3/6drm/amdgpu: add job->pasid in check as amdgpu_job could be NULLdrivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c+1 -11 reply
4/6drm/amdgpu/userq: use pm_runtime_resume_and_get and fix err handlingdrivers/gpu/drm/amd/amdgpu/amdgpu_userq.c+8 -52 replies
5/6drm/amdgpu/userq: unmap is to be called before freeing doorbell/wptr bodrivers/gpu/drm/amd/amdgpu/amdgpu_userq.c+13 -151 reply
6/6drm/amdgpu/userq: unmap_helper dont return the queue statedrivers/gpu/drm/amd/amdgpu/amdgpu_userq.c+1 -12 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchChristian KönigAlex Deucher
1/6R-b
2/6A-b
3/6R-b
4/6A-b R-b
5/6R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] Never take root bo reservation locks with userq_mutex

v1: Fixes the locks issue in all the places where userq_mutex is taken and then vm->root.bo reservation lock is next.
v2: Fix the minor comment on the patches.
v3: Add some more userq fixes found during testing

Sunil Khatri (6):
drm/amdgpu/userq: caller to take reserv lock for vas_list_cleanup drm/amdgpu/userq: hold root bo lock in caller of input_va_validate drm/amdgpu: add job->pasid in check as amdgpu_job could be NULL drm/amdgpu/userq: use pm_runtime_resume_and_get and fix err handling drm/amdgpu/userq: unmap is to be called before freeing doorbell/wptr
bo
drm/amdgpu/userq: unmap_helper dont return the queue state

 .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c  |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c     | 86 ++++++++++---------
 drivers/gpu/drm/amd/amdgpu/mes_userqueue.c    | 21 +++++
 3 files changed, 69 insertions(+), 40 deletions(-)
Signature · 1 line
2.34.1