Skip to content

drm/nouveau: stability fixes for NVAC (MCP79/MCP7A)

Marek Czernohous dri-devel nouveau 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/nouveau/pci: use nv46 MSI rearm for G94 (NVAC/MCP79)drivers/gpu/drm/nouveau/nvkm/subdev/pci/g94.c+1 -10 replies
2/3drm/nouveau/kms: add NULL check for CRTC in nv50_sor_atomic_disabledrivers/gpu/drm/nouveau/dispnv50/disp.c+7 -10 replies
3/3drm/nouveau/dp: retry link check once on HPD IRQ before disconnectdrivers/gpu/drm/nouveau/nouveau_display.c+4 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] drm/nouveau: stability fixes for NVAC (MCP79/MCP7A)

Hi,

this is my first patch series for the kernel. I'm running an Apple Mac Mini with an NVAC (MCP79) chipset and DisplayPort output, and hit three separate stability issues with the nouveau driver on kernel 6.18.

The patches are independent but together they bring the NVAC from "needs NvMSI=0 workaround and can't run Wayland" to fully stable operation with MSI enabled, working DPMS, and functional Wayland (tested with Weston).

Patch 1: The MSI re-arm function for G94 uses memory-mapped register access (nv40), which is unreliable on NVAC — the sister chipset NVAA already has MSI disabled entirely for this reason. Switching to the PCI config space method (nv46) fixes sporadic FIFO errors and hangs.

Patch 2: nv50_sor_atomic_disable() dereferences nv_encoder->crtc unconditionally via container_of(). Under Wayland atomic modesetting, the CRTC can become NULL between check and commit, causing a kernel crash. Adding a NULL guard fixes Wayland session teardown.

Patch 3: Transient DisplayPort link glitches on NVAC cause unnecessary disconnect/reconnect cycles. A single 100ms retry in the HPD IRQ handler catches these without affecting real unplug detection.

All three patches were tested on the same machine (NVAC 0xac080b1, DP output) over multiple days with DPMS cycling, VT switching, and Wayland sessions.

Thanks,
Marek

Marek Czernohous (3):
drm/nouveau/pci: use nv46 MSI rearm for G94 (NVAC/MCP79) drm/nouveau/kms: add NULL check for CRTC in nv50_sor_atomic_disable drm/nouveau/dp: retry link check once on HPD IRQ before disconnect

 drivers/gpu/drm/nouveau/dispnv50/disp.c       | 8 +++++++-
 drivers/gpu/drm/nouveau/nouveau_display.c     | 4 ++++
 drivers/gpu/drm/nouveau/nvkm/subdev/pci/g94.c | 2 +-
 3 files changed, 12 insertions(+), 2 deletions(-)
Signature · 1 line
2.52.0