Skip to content

ALSA: caiaq: fix UAF, double-free, and USB refcount bugs

Berk Cem Goksel linux-sound lkml stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Correct "Fixes:" tags on both patches
- Remove null check before the usb_put_dev() call in card_free()

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ALSA: caiaq: fix use-after-free and double-free in setup_card()sound/usb/caiaq/device.c+1 -01 reply
2/2ALSA: caiaq: take a reference on the USB device in create_card()sound/usb/caiaq/device.c+2 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] ALSA: caiaq: fix UAF, double-free, and USB refcount bugs

This series fixes two bugs in the caiaq USB sound driver, both reachable via a malformed or malicious USB device using raw-gadget + dummy_hcd.

Patch 1 adds a missing return after snd_card_free() in setup_card() when snd_card_register() fails. Without it, execution falls through to snd_usb_caiaq_control_init() on a freed card (use-after-free), and the caller then leaves the freed pointer in usb_set_intfdata(), producing a double-free on disconnect.

Patch 2 takes a proper reference on the parent USB device in create_card() with usb_get_dev() and drops it with usb_put_dev() in the private_free callback. It also removes a usb_reset_device() call from that callback, which was both racing against an already-freed usb_device and inappropriate in a teardown path.

A related stack out-of-bounds read in init_card() was sent separately and has already been applied; this series is the remainder of that investigation.

Tested on 7.0.0-rc5 arm64 with KASAN and lockdep enabled. Reproducers require CONFIG_USB_RAW_GADGET and CONFIG_USB_DUMMY_HCD and are available on request.

Changes in v2:
- Correct "Fixes:" tags on both patches
- Remove null check before the usb_put_dev() call in card_free()

Berk Cem Goksel (2):
ALSA: caiaq: fix use-after-free and double-free in setup_card()
ALSA: caiaq: take a reference on the USB device in create_card()

 sound/usb/caiaq/device.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.34.1