Skip to content

drm/i915: Some fixes/cleanups to the BIOS FB stuff

Ville Syrjala intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/i915: Introduce sanity to the plane_config pointer vs. array thingdrivers/gpu/drm/i915/display/intel_initial_plane.c include/drm/intel/display_parent_interface.h+14 -91 reply
2/10drm/i915: Remove 'mem' and 'phy_base' from struct intel_initial_plane_configdrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/i915_initial_plane.c+6 -91 reply
3/10drm/i915: Don't pass the whole plane_config to initial_plane_phys()drivers/gpu/drm/i915/i915_initial_plane.c+3 -51 reply
4/10drm/i915: Make plane_config->fb a struct drm_framebuffer*drivers/gpu/drm/i915/display/i9xx_plane.c drivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_initial_plane.c +3 more+12 -123 replies
5/10drm/i915: Move initial plane vblank wait into display codedrivers/gpu/drm/i915/display/intel_initial_plane.c drivers/gpu/drm/i915/i915_initial_plane.c drivers/gpu/drm/xe/display/xe_initial_plane.c +1 more+21 -281 reply
6/10drm/i915: Use a 1 second timeout for the polling vblank waitdrivers/gpu/drm/i915/display/intel_initial_plane.c+1 -11 reply
7/10drm/i915: Reject tile4 BIOS FBdrivers/gpu/drm/i915/display/intel_initial_plane.c+0 -11 reply
8/10drm/i915: Reject X/Y tiled BIOS FB if we don't have fenced regionsdrivers/gpu/drm/i915/display/intel_initial_plane.c+5 -11 reply
9/10drm/i915: Completely reject DPT BIOS FBs.drivers/gpu/drm/i915/display/intel_initial_plane.c drivers/gpu/drm/i915/display/skl_universal_plane.c+9 -61 reply
10/10drm/i915: Reject BIOS FB rotation in common codedrivers/gpu/drm/i915/display/intel_initial_plane.c+10 -01 reply

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchJani Nikula
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] drm/i915: Some fixes/cleanups to the BIOS FB stuff

From: Ville Syrjälä <[email protected]>

While doing trying to add decent abstractions for the FB pinning I ran into the BIOS FB takeover code, and it didn't exactly impress me.

Here's a prep series trying to cover some of the issues I saw that aren't really directly related to the FB pinning topic.

Ville Syrjälä (10):
drm/i915: Introduce sanity to the plane_config pointer vs. array thing drm/i915: Remove 'mem' and 'phy_base' from struct
intel_initial_plane_config
drm/i915: Don't pass the whole plane_config to initial_plane_phys() drm/i915: Make plane_config->fb a struct drm_framebuffer* drm/i915: Move initial plane vblank wait into display code drm/i915: Use a 1 second timeout for the polling vblank wait drm/i915: Reject tile4 BIOS FB
drm/i915: Reject X/Y tiled BIOS FB if we don't have fenced regions drm/i915: Completely reject DPT BIOS FBs.
drm/i915: Reject BIOS FB rotation in common code

 drivers/gpu/drm/i915/display/i9xx_plane.c     |  2 +-
 .../drm/i915/display/intel_display_types.h    |  4 +-
 .../drm/i915/display/intel_initial_plane.c    | 79 +++++++++++++++----
 .../drm/i915/display/skl_universal_plane.c    |  8 +-
 drivers/gpu/drm/i915/i915_initial_plane.c     | 27 +++----
 drivers/gpu/drm/xe/display/xe_initial_plane.c | 21 +----
 include/drm/intel/display_parent_interface.h  |  4 +-
 7 files changed, 77 insertions(+), 68 deletions(-)
Signature · 1 line
2.52.0