Skip to content

ip6mr: No RTNL for RTNL_FAMILY_IP6MR rtnetlink.

Kuniyuki Iwashima netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest15 patches 4 repliesIn review

Changes in v2 from the cover letter

Add patch 8 & 9 for ->exit_rtnl() conversion and
drop 2 trivial patches (patch 2 & 14 in v1)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15selftest: net: Extend ipmr.c for IP6MR.tools/testing/selftests/net/forwarding/ipmr.c+110 -530 replies
2/15ip6mr: Annotate access to mrt->mroute_do_{pim,assert,wrvifwhole}.net/ipv6/ip6mr.c+9 -90 replies
3/15ip6mr: Use MAXMIFS in mr6_msgsize().net/ipv6/ip6mr.c+4 -50 replies
4/15ip6mr: Allocate skb earlier in ip6mr_rtm_getroute().net/ipv6/ip6mr.c+14 -100 replies
5/15ip6mr: Convert ip6mr_rtm_getroute() to RCU.net/ipv6/ip6mr.c+7 -40 replies
6/15ip6mr: Convert ip6mr_rtm_dumproute() to RCU.net/ipv6/ip6mr.c+20 -90 replies
7/15net: Remove rtnl_held of struct fib_dump_filter.include/net/ip_fib.h net/ipv4/fib_frontend.c net/ipv4/ipmr.c +3 more+10 -250 replies
8/15ipmr: Free mr_table after RCU grace period.include/linux/mroute_base.h net/ipv4/ipmr.c+30 -230 replies
9/15ip6mr: Free mr_table after RCU grace period.net/ipv6/ip6mr.c+30 -230 replies
10/15ip6mr: Move unregister_netdevice_many() out of mroute_clean_tables().net/ipv6/ip6mr.c+17 -80 replies
11/15ip6mr: Move unregister_netdevice_many() out of ip6mr_free_table().net/ipv6/ip6mr.c+15 -80 replies
12/15ip6mr: Convert ip6mr_net_exit_batch() to ->exit_rtnl().net/ipv6/ip6mr.c+13 -170 replies
13/15ip6mr: Remove RTNL in ip6mr_rules_init() and ip6mr_net_init().net/ipv6/ip6mr.c+5 -100 replies
14/15ip6mr: Call fib_rules_unregister() without RTNL.net/ipv6/ip6mr.c+11 -20 replies
15/15ip6mr: Replace RTNL with a dedicated mutex for MFC.include/net/netns/ipv6.h net/ipv6/ip6mr.c+15 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 net-next 00/15] ip6mr: No RTNL for RTNL_FAMILY_IP6MR rtnetlink.

This series is the IPv6 version of

https://lore.kernel.org/netdev/[email protected]/

and removes RTNL from ip6mr rtnetlink handlers.

After this series, there are a few RTNL left in net/ipv6/ipmr.c and such users will be converted to per-netns RTNL in another series.

Patch 1 extends the ipmr selftest to exercise most of the RTNL
paths in net/ipv6/ipmr.c

Patch 2 - 6 converts RTM_GETROUTE handlers to RCU.

Patch 7 removes struct fib_dump_filter.rtnl_held.

Patch 8 - 9 use RCU for mr_table for CONFIG_IP_MROUTE_MULTIPLE_TABLES=n
and CONFIG_IPV6_MROUTE_MULTIPLE_TABLES=n for ->exit_rtnl().

Patch 10 - 12 converts ->exit_batch() to ->exit_rtnl() to
save one RTNL in cleanup_net().

Patch 13 - 14 removes unnecessary RTNL during setup_net()
failure.

Patch 15 drops RTNL for MRT6_(ADD|DEL)_MFC(_PROXY)?.

Changes:
v2:
Add patch 8 & 9 for ->exit_rtnl() conversion and
drop 2 trivial patches (patch 2 & 14 in v1)

v1: https://lore.kernel.org/netdev/[email protected]/

Kuniyuki Iwashima (15):
selftest: net: Extend ipmr.c for IP6MR.
ip6mr: Annotate access to mrt->mroute_do_{pim,assert,wrvifwhole}.
ip6mr: Use MAXMIFS in mr6_msgsize().
ip6mr: Allocate skb earlier in ip6mr_rtm_getroute().
ip6mr: Convert ip6mr_rtm_getroute() to RCU.
ip6mr: Convert ip6mr_rtm_dumproute() to RCU.
net: Remove rtnl_held of struct fib_dump_filter.
ipmr: Free mr_table after RCU grace period.
ip6mr: Free mr_table after RCU grace period.
ip6mr: Move unregister_netdevice_many() out of mroute_clean_tables().
ip6mr: Move unregister_netdevice_many() out of ip6mr_free_table().
ip6mr: Convert ip6mr_net_exit_batch() to ->exit_rtnl().
ip6mr: Remove RTNL in ip6mr_rules_init() and ip6mr_net_init().
ip6mr: Call fib_rules_unregister() without RTNL.
ip6mr: Replace RTNL with a dedicated mutex for MFC.

 include/linux/mroute_base.h                   |   2 +
 include/net/ip_fib.h                          |   1 -
 include/net/netns/ipv6.h                      |   1 +
 net/ipv4/fib_frontend.c                       |  19 +-
 net/ipv4/ipmr.c                               |  55 +++--
 net/ipv6/ip6_fib.c                            |   1 -
 net/ipv6/ip6mr.c                              | 233 +++++++++++-------
 net/mpls/af_mpls.c                            |   6 +-
 tools/testing/selftests/net/forwarding/ipmr.c | 163 ++++++++----
 9 files changed, 289 insertions(+), 192 deletions(-)
Signature · 1 line
2.53.0.1213.gd9a14994de-goog