Skip to content

Use kmalloc_nolock() universally in BPF local storage

Amery Hung bpf netdev 2 versions Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesApplied 3/3
  2. v13 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Fix build (CI, Alexei)

Patches in v2 All 3 applied

#Subject and filesSizeRepliesApplied
1/3selftests/bpf: Remove kmalloc tracing from local storage create benchtools/testing/selftests/bpf/benchs/bench_local_storage_create.c tools/testing/selftests/bpf/progs/bench_local_storage_create.c+6 -260 repliesApplied
2/3bpf: Use kmalloc_nolock() universally in local storageinclude/linux/bpf_local_storage.h kernel/bpf/bpf_cgrp_storage.c kernel/bpf/bpf_inode_storage.c +3 more+21 -1255 repliesApplied
3/3bpf: Remove gfp_flags plumbing from bpf_local_storage_update()include/linux/bpf_local_storage.h kernel/bpf/bpf_cgrp_storage.c kernel/bpf/bpf_inode_storage.c +4 more+30 -670 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH bpf-next v2 0/3] Use kmalloc_nolock() universally in BPF local storage

Socket local storage did not convert to use kmalloc_nolock() since there were observable performance degredation due to kfree_nolock() hitting the slow path and the lack of kfree_rcu()-like batching freeing. Now that these concern were addressed in slub, convert all remaining local storage flavors to use kmalloc_nolock().

v1 -> v2:
- Fix build (CI, Alexei)

Amery Hung (3):
selftests/bpf: Remove kmalloc tracing from local storage create bench
bpf: Use kmalloc_nolock() universally in local storage
bpf: Remove gfp_flags plumbing from bpf_local_storage_update()

 include/linux/bpf_local_storage.h             |  15 +-
 kernel/bpf/bpf_cgrp_storage.c                 |  11 +-
 kernel/bpf/bpf_inode_storage.c                |  11 +-
 kernel/bpf/bpf_local_storage.c                | 146 +++---------------
 kernel/bpf/bpf_task_storage.c                 |  11 +-
 kernel/bpf/verifier.c                         |  26 ----
 net/core/bpf_sk_storage.c                     |  23 ++-
 .../bpf/benchs/bench_local_storage_create.c   |  21 +--
 .../bpf/progs/bench_local_storage_create.c    |  11 --
 9 files changed, 57 insertions(+), 218 deletions(-)
Signature · 1 line
2.52.0