Skip to content

bpf: arg tracking for imprecise/multi-offset BPF_ST/STX

Eduard Zingerman bpf 3 versions Applied

Status from this message: This series was applied to bpf/bpf.git (master)

Get series with b4
b4 am [email protected] change-id 20260413-stacklive-fixes-42e258cf0397

Versions newest first

  1. v2 Latest posting 2/22 patches 0 repliesApplied 2/2
  2. v2 posting 1/22 patches 3 repliesSuperseded
  3. v13 patches 0 repliesSuperseded

v2 -> v3 from the cover letter

- Use check_add_overflow() in arg_add() (Alexei).
- Add missing fixes tag (CI bot).
- Remove unused __imm in the selftest (sashiko). v1 -> v2:
- Delete the OFF_IMPRECISE constant, always rely on arg_track->cnt == 0 as a marker the offset is imprecise. (Alexei).
- Squash all patches together to simplify backporting to 'bpf' branch (Alexei).

Patches in v2 posting 2/2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2bpf: fix arg tracking for imprecise/multi-offset BPF_ST/STXkernel/bpf/liveness.c+62 -520 repliesApplied
2/2selftests/bpf: arg tracking for imprecise/multi-offset BPF_ST/STXtools/testing/selftests/bpf/progs/verifier_live_stack.c+193 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH bpf-next v2 0/2] bpf: arg tracking for imprecise/multi-offset BPF_ST/STX

When the static arg tracking analysis encounters a store through a pointer with imprecise or multi-offset destination, it must use weak updates (join) instead of strong updates (overwrite) for the affected at_stack slots. At runtime only one slot is actually written; the others retain their old values.

Two cases are addressed:
- BPF_STX, handled by spill_to_stack(). It was gated on dst_is_local_fp = (frame == depth), which missed ARG_IMPRECISE pointers entirely.
- BPF_ST, handled by clear_stack_for_all_offs(). It delegates to clear_overlapping_stack_slots() which unconditionally set at_stack[i] = none. Change to at_stack[i] = join(old, none) when multiple candidate slots exist (cnt != 1), so that untouched slots preserve their tracked values.

No veristat diff compared to current master when tested on selftests, sched_ext, cilium and a set of Meta internal programs.

This addresses issues reported by sashiko for patch #7 in [1].

[1] https://sashiko.dev/#/patchset/20260410-patch-set-v4-0-5d4eecb343db%40gmail.com

Changelog:
v2 -> v3:
- Use check_add_overflow() in arg_add() (Alexei).
- Add missing fixes tag (CI bot).
- Remove unused __imm in the selftest (sashiko). v1 -> v2:
- Delete the OFF_IMPRECISE constant, always rely on arg_track->cnt == 0 as a marker the offset is imprecise. (Alexei).
- Squash all patches together to simplify backporting to 'bpf' branch (Alexei).

v1: https://lore.kernel.org/bpf/[email protected]/T/
v2: https://lore.kernel.org/bpf/[email protected]/T/
---
Eduard Zingerman (2):
bpf: fix arg tracking for imprecise/multi-offset BPF_ST/STX selftests/bpf: arg tracking for imprecise/multi-offset BPF_ST/STX

 kernel/bpf/liveness.c                              | 114 ++++++------
 .../selftests/bpf/progs/verifier_live_stack.c      | 193 +++++++++++++++++++++
 2 files changed, 255 insertions(+), 52 deletions(-)

---
base-commit: 71b500afd2f7336f5b6c6026f2af546fc079be26
change-id: 20260413-stacklive-fixes-42e258cf0397