Skip to content

drm/hibmc: Fix plane helpers and convert to gem-shmem

Thomas Zimmermann dri-devel sashiko sashiko-reviews stable 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 7 repliesIn review
  2. v34 patches 4 repliesSuperseded
  3. v24 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches8 repliesSuperseded

Changes in v4 from the cover letter

- verify framebuffer pitch aligns to 128
- store fb in local variable in atomic_update (Yongbang) v3:
- fix coding style
- rebase on display-detection fixes

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/hibmc: Use drm_atomic_helper_check_plane_state()drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c+14 -320 replies
2/6drm/hibmc: Fix list of formats on the primary planedrivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c+2 -40 replies
3/6drm/hibmc: Store fb in variable in atomic_updatedrivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c+7 -81 reply
4/6drm/hibmc: Do not use cpp from struct drm_format_infodrivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c+9 -21 reply
5/6drm/hibmc: Verify the framebuffer pitch to be a multiple of 128drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c+17 -11 reply
6/6drm/hibmc: Use gem-shmem with shadow-plane helpers for memory managementdrivers/gpu/drm/drm_gem_shmem_helper.c drivers/gpu/drm/hisilicon/hibmc/Kconfig drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c +3 more+100 -354 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchYongbang Shi
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] drm/hibmc: Fix plane helpers and convert to gem-shmem

Convert hibmc's memory management from gem-vram ot gem-shmem. Fix a number of bugs in preparation.

Patches 1 to 5 fix various bugs and minor issues in the plane code.

Patch 6 replaces gem-vram with gem-shmem. The rational is that gem-vram has corner cases on low-end devices and is limited in functionality. The commit messages state a list of possible issues.

Switching to gem-shmem avoids these problems. It also enables buffer sharing via dma_buf, which improves the hibmc driver's integration with the overall graphics ecosystem.

We've done these changes on drivers for similar hardware, such as ast and mgag200. Hibmc is the last of these drivers to run on gem-shmem. Gem-vram instead is deprecated and can hopefully be removed in a later release.

Tested on an RH1288 v3 system.

v4:
- verify framebuffer pitch aligns to 128
- store fb in local variable in atomic_update (Yongbang) v3:
- fix coding style
- rebase on display-detection fixes
v2:
- extend commit message of patch 2 (Yongbang)
- so not select TTM any longer

Thomas Zimmermann (6):
drm/hibmc: Use drm_atomic_helper_check_plane_state() drm/hibmc: Fix list of formats on the primary plane drm/hibmc: Store fb in variable in atomic_update drm/hibmc: Do not use cpp from struct drm_format_info drm/hibmc: Verify the framebuffer pitch to be a multiple of 128 drm/hibmc: Use gem-shmem with shadow-plane helpers for memory
management

 drivers/gpu/drm/drm_gem_shmem_helper.c        |  22 +++-
 drivers/gpu/drm/hisilicon/hibmc/Kconfig       |   4 +-
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_de.c    | 110 +++++++++---------
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c   |  78 ++++++++++---
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h   |   5 +
 include/drm/drm_gem_shmem_helper.h            |   4 +
 6 files changed, 145 insertions(+), 78 deletions(-)
Signature · 1 line
2.54.0