Skip to content

Correct bug parsing DisCo booleans

Charles Keepax linux-sound 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2regmap: sdw-mbq: Allow defers on undeferrable controlsdrivers/base/regmap/regmap-sdw-mbq.c+18 -180 replies
2/2ASoC: SDCA: Fix reading of mipi-sdca-control-deferrablesound/soc/sdca/sdca_functions.c+5 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Correct bug parsing DisCo booleans

MIPI DisCo uses the unfortunate convention of allowing boolean properties to be present but having a zero value. Opposed to the normal convention of simply not specifying the property. Fix an issue in the SDCA code where mipi-sdca-control-deferrable is not parsed correctly.

However, we also have some shipping ACPIs where these properties are not specified correctly. Update the MBQ regmap to attempt defers albeit with a warning in the case where a control attempts to defer but is not marked at such. There is little down side to this as if defer is genuinely not supported then the control will just return the same error again.

Thanks,
Charles

Charles Keepax (2):
regmap: sdw-mbq: Allow defers on undeferrable controls
ASoC: SDCA: Fix reading of mipi-sdca-control-deferrable

 drivers/base/regmap/regmap-sdw-mbq.c | 36 ++++++++++++++--------------
 sound/soc/sdca/sdca_functions.c      |  7 ++++--
 2 files changed, 23 insertions(+), 20 deletions(-)
Signature · 1 line
2.47.3