Skip to content

Input: analog: fix coding style violations

Akash Sukhavasi linux-input lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Input: analog: Fix coding style - trailing statements on same linedrivers/input/joystick/analog.c+32 -130 replies
2/2Input: analog: Fix coding style - indentation and parenthesis spacingdrivers/input/joystick/analog.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Input: analog: fix coding style violations

This patch series resolves 15 errors and addresses several warnings reported by checkpatch.pl in the drivers/input/joystick/analog.c driver. The original code contained multiple instances of trailing statements on single-line conditionals, as well as minor indentation and spacing issues that are in violation of kernel coding style.

This series breaks the cleanups into two logical parts:
1. Fixing trailing statements (moving them to their own lines).
2. Correcting indentation and parenthesis spacing.

Several warnings are intentionally left unaddressed, as they require semantic or functional changes outside the scope of this formatting cleanup:
- printk() to pr_warn()/pr_info() conversions
- simple_strtoul() to kstrtoul() conversion
- Filename strings embedded in printk() messages
- Quoted string split across lines
- Suspect indent on fail3 label

Tested with: scripts/checkpatch.pl --strict on the final patch.

---
Akash Sukhavasi (2):
Input: analog: Fix coding style - trailing statements on same line
Input: analog: Fix coding style - indentation and parenthesis spacing

 drivers/input/joystick/analog.c | 49 +++++++++++++++++++++++----------
 1 file changed, 34 insertions(+), 15 deletions(-)
Signature · 1 line
2.53.0