Skip to content

usbip: vhci_hcd: fix NULL deref and NR_HCS upper bound

Adrian Wowk linux-usb lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2usbip: vhci_hcd: fix NULL deref in status_show_vhcidrivers/usb/usbip/vhci_sysfs.c+29 -231 reply
2/2usbip: vhci_hcd: reduce CONFIG_USBIP_VHCI_NR_HCS upper bound to 32drivers/usb/usbip/Kconfig+1 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchShuah Khan
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] usbip: vhci_hcd: fix NULL deref and NR_HCS upper bound

These two patches fix a NULL pointer dereference in vhci_sysfs.c triggered when a VHCI host controller fails to probe, and tighten the Kconfig upper bound for USBIP_VHCI_NR_HCS to reflect the real maximum imposed by USB_MAXBUS.

Tested on Ubuntu 6.8.0-110-generic (6.8.12) on a Dell PowerEdge R640, issue is reproducible with CONFIG_USBIP_VHCI_NR_HCS > 32 or potentially lower if there is already other USB hardware connected.

Adrian Wowk (2):
usbip: vhci_hcd: fix NULL deref in status_show_vhci
usbip: vhci_hcd: reduce CONFIG_USBIP_VHCI_NR_HCS upper bound to 32

 drivers/usb/usbip/Kconfig      |  2 +-
 drivers/usb/usbip/vhci_sysfs.c | 52 +++++++++++++++++++---------------
 2 files changed, 30 insertions(+), 24 deletions(-)
Signature · 1 line
2.53.0