Skip to content

spi: fix explicit controller deregistration

Johan Hovold linux-spi lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8spi: cadence: fix controller deregistrationdrivers/spi/spi-cadence.c+5 -10 replies
2/8spi: cadence-quadspi: fix controller deregistrationdrivers/spi/spi-cadence-quadspi.c+2 -20 replies
3/8spi: mpc52xx: fix controller deregistrationdrivers/spi/spi-mpc52xx.c+2 -10 replies
4/8spi: mpc52xx: fix use-after-free on unbinddrivers/spi/spi-mpc52xx.c+2 -10 replies
5/8spi: mxic: fix controller deregistrationdrivers/spi/spi-mxic.c+2 -10 replies
6/8spi: orion: fix controller deregistrationdrivers/spi/spi-orion.c+6 -10 replies
7/8spi: topcliff-pch: fix controller deregistrationdrivers/spi/spi-topcliff-pch.c+6 -10 replies
8/8spi: topcliff-pch: fix use-after-free on unbinddrivers/spi/spi-topcliff-pch.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] spi: fix explicit controller deregistration

Turns out we have a few drivers that get the tear down ordering wrong also when not using device managed registration (cf. [1] and [2]).

Fix this to avoid issues like system errors due to unclocked accesses, NULL-pointer dereferences, hangs or failed I/O during during deregistration (e.g. when powering down devices).

Johan

[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/

Johan Hovold (8):
spi: cadence: fix controller deregistration
spi: cadence-quadspi: fix controller deregistration
spi: mpc52xx: fix controller deregistration
spi: mpc52xx: fix use-after-free on unbind
spi: mxic: fix controller deregistration
spi: orion: fix controller deregistration
spi: topcliff-pch: fix controller deregistration
spi: topcliff-pch: fix use-after-free on unbind

 drivers/spi/spi-cadence-quadspi.c |  4 ++--
 drivers/spi/spi-cadence.c         |  6 +++++-
 drivers/spi/spi-mpc52xx.c         |  6 ++++--
 drivers/spi/spi-mxic.c            |  3 ++-
 drivers/spi/spi-orion.c           |  7 ++++++-
 drivers/spi/spi-topcliff-pch.c    | 11 ++++++++---
 6 files changed, 27 insertions(+), 10 deletions(-)
Signature · 1 line
2.52.0