Skip to content

RFC target/mips: Translate MSA vector load/store opcodes

Philippe Mathieu-Daudé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 RFC Latest6 patches 7 repliesIn review
  2. v4 RFC2 patches 1 replySuperseded

Changes in v5 from the cover letter

- No algorithm change
- Split to ease review

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6target/mips: Expand TRANS_DF_iv() macro for MSA Load/Storetarget/mips/tcg/msa_translate.c+47 -121 reply
2/6target/mips: Convert MSA LD/ST.B (Byte Vector)target/mips/tcg/msa_helper.c target/mips/tcg/msa_helper.h.inc target/mips/tcg/msa_translate.c+24 -351 reply
3/6target/mips: Convert MSA LD/ST.H (Halfword Vector)target/mips/tcg/msa_helper.c target/mips/tcg/msa_helper.h.inc target/mips/tcg/msa_translate.c+26 -552 replies
4/6target/mips: Convert MSA LD/ST.W (Word Vector)target/mips/tcg/msa_helper.c target/mips/tcg/msa_helper.h.inc target/mips/tcg/msa_translate.c+14 -541 reply
5/6target/mips: Convert MSA LD/ST.D (Doubleword Vector)target/mips/tcg/msa_helper.c target/mips/tcg/msa_helper.h.inc target/mips/tcg/msa_translate.c+1 -761 reply
6/6target/mips: Endian-swap MSA LD/ST.D (Doubleword Vector)target/mips/tcg/msa_translate.c+4 -01 reply

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchRichard Henderson
1/6R-b
2/6R-b
3/6
4/6R-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [RFC PATCH v5 0/6] target/mips: Translate MSA vector load/store opcodes

Since v4:
- No algorithm change
- Split to ease review

Hi Richard,

I tried to implement your suggestion from v3 [*]. Unfortunately the box where I had the MSA test suite got erased, so it will take me some time to restore the setup. I was surprised these patches pass our CI tests so I added a pair of abort() which didn't fire, so this code path isn't tested at all there. Anyhow, do you mind having a quick look to see this is going in the right direction?

Thanks!

Phil.

[*] https://lore.kernel.org/qemu-devel/[email protected]/

Philippe Mathieu-Daudé (6):
target/mips: Expand TRANS_DF_iv() macro for MSA Load/Store target/mips: Convert MSA LD/ST.B (Byte Vector) target/mips: Convert MSA LD/ST.H (Halfword Vector) target/mips: Convert MSA LD/ST.W (Word Vector) target/mips: Convert MSA LD/ST.D (Doubleword Vector) target/mips: Endian-swap MSA LD/ST.D (Doubleword Vector)

 target/mips/tcg/msa_helper.h.inc |   9 --
 target/mips/tcg/msa_helper.c     | 176 -------------------------------
 target/mips/tcg/msa_translate.c  |  93 +++++++++++++---
 3 files changed, 81 insertions(+), 197 deletions(-)
Signature · 1 line
2.53.0