Skip to content

wifi: carl9170: firmware trust boundary hardening

Tristan Madani linux-wireless lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 7 repliesApplied
  2. v23 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Regenerated from wireless-next with proper git format-patch.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3wifi: carl9170: bound memcpy length in cmd callback to prevent OOB readdrivers/net/wireless/ath/carl9170/rx.c+2 -11 reply
2/3wifi: carl9170: fix OOB read from off-by-two in TX status handlerdrivers/net/wireless/ath/carl9170/tx.c+1 -11 reply
3/3wifi: carl9170: fix buffer overflow in rx_stream failover pathdrivers/net/wireless/ath/carl9170/rx.c+3 -12 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChristian Lamparter
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] wifi: carl9170: firmware trust boundary hardening

From: Tristan Madani <[email protected]>

This series adds missing bounds checks for firmware-controlled fields in the carl9170 USB driver.

Patch 1 bounds the cmd callback memcpy to prevent heap overflow from an oversized firmware response. Patch 2 fixes an off-by-two in the TX status handler. Patch 3 caps the failover copy to rx_failover_missing bytes, using min_t per Christian Lamparter.

Changes in v3:
- Regenerated from wireless-next with proper git format-patch.

Changes in v2:
- Use min_t() instead of separate if-check in patch 3, per Christian Lamparter.

Tristan Madani (3):
wifi: carl9170: bound memcpy length in cmd callback to prevent OOB
read
wifi: carl9170: fix OOB read from off-by-two in TX status handler
wifi: carl9170: fix buffer overflow in rx_stream failover path

 drivers/net/wireless/ath/carl9170/rx.c | 7 +++++--
 drivers/net/wireless/ath/carl9170/tx.c | 2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)
Signature · 1 line
2.47.3