Skip to content

wifi: mwifiex: firmware trust boundary hardening

Tristan Madani linux-wireless lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 11 repliesIn review
  2. v26 patches 1 replySuperseded

Changes in v3 from the cover letter

- Regenerated from wireless-next with proper git format-patch.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6wifi: mwifiex: fix OOB write from firmware queue_index in WMM status responsedrivers/net/wireless/marvell/mwifiex/wmm.c+5 -01 reply
2/6wifi: mwifiex: fix OOB write from firmware TID in ADDBA response handlerdrivers/net/wireless/marvell/mwifiex/11n.c+5 -01 reply
3/6wifi: mwifiex: fix OOB read from firmware sta_count in station list responsedrivers/net/wireless/marvell/mwifiex/sta_cmdresp.c+9 -16 replies
4/6wifi: mwifiex: fix OOB read in scan response from mismatched TLV data sizesdrivers/net/wireless/marvell/mwifiex/scan.c+6 -31 reply
5/6wifi: mwifiex: fix OOB read from firmware intf_num in multichannel eventdrivers/net/wireless/marvell/mwifiex/sta_event.c+8 -01 reply
6/6wifi: mwifiex: fix OOB read from inflated TLV length in IBSS peer eventdrivers/net/wireless/marvell/mwifiex/sta_event.c+4 -01 reply

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchBrian Norris
1/6
2/6A-b
3/6A-b
4/6A-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] wifi: mwifiex: firmware trust boundary hardening

From: Tristan Madani <[email protected]>

This series adds missing bounds checks for firmware-controlled fields in the Marvell mwifiex driver.

Patches cover: WMM queue_index, ADDBA TID, station list count, scan response TLV lengths, multichannel intf_num, and IBSS peer TLV length.

Changes in v3:
- Regenerated from wireless-next with proper git format-patch.

Changes in v2:
- No code changes from v1.

Tristan Madani (6):
wifi: mwifiex: fix OOB write from firmware queue_index in WMM status
response
wifi: mwifiex: fix OOB write from firmware TID in ADDBA response
handler
wifi: mwifiex: fix OOB read from firmware sta_count in station list
response
wifi: mwifiex: fix OOB read in scan response from mismatched TLV data
sizes
wifi: mwifiex: fix OOB read from firmware intf_num in multichannel
event
wifi: mwifiex: fix OOB read from inflated TLV length in IBSS peer
event

 drivers/net/wireless/marvell/mwifiex/11n.c         |  5 +++++
 drivers/net/wireless/marvell/mwifiex/scan.c        |  9 ++++++---
 drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c | 10 +++++++++-
 drivers/net/wireless/marvell/mwifiex/sta_event.c   | 12 ++++++++++++
 drivers/net/wireless/marvell/mwifiex/wmm.c         |  5 +++++
 5 files changed, 37 insertions(+), 4 deletions(-)
Signature · 1 line
2.47.3