Skip to content

fuse: improve transport and fs layer separation

Miklos Szeredi fuse-devel linux-fsdevel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest32 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/32fuse: move request timeout code to a new source filefs/fuse/Makefile fs/fuse/dev.c fs/fuse/dev.h +5 more+173 -1450 replies
2/32fuse: add struct fuse_chanfs/fuse/cuse.c fs/fuse/dev.c fs/fuse/dev.h +4 more+50 -50 replies
3/32fuse: move fuse_iqueue to fuse_chanfs/fuse/cuse.c fs/fuse/dev.c fs/fuse/dev.h +7 more+146 -1370 replies
4/32fuse: move fuse_dev and fuse_pqueue to dev.cfs/fuse/dev.c fs/fuse/dev.h fs/fuse/fuse_dev_i.h +2 more+144 -1400 replies
5/32fuse: move 'devices' member from fuse_conn to fuse_chanfs/fuse/dev.c fs/fuse/fuse_dev_i.h fs/fuse/fuse_i.h +2 more+17 -120 replies
6/32fuse: move background queuing related members to fuse_chanfs/fuse/control.c fs/fuse/dev.c fs/fuse/dev.h +7 more+73 -712 replies
7/32fuse: move request blocking related members to fuse_chanfs/fuse/control.c fs/fuse/cuse.c fs/fuse/dev.c +5 more+71 -710 replies
8/32fuse: move io_uring related members to fuse_chanfs/fuse/dev.c fs/fuse/dev_uring.c fs/fuse/dev_uring_i.h +3 more+26 -260 replies
9/32fuse: move interrupt related members to fuse_chanfs/fuse/dev.c fs/fuse/fuse_dev_i.h fs/fuse/fuse_i.h+5 -50 replies
10/32fuse: split off fch->lock from fc->lockfs/fuse/dev.c fs/fuse/dev_uring.c fs/fuse/fuse_dev_i.h +2 more+40 -250 replies
11/32fuse: add back pointer from fuse_chan to fuse_connfs/fuse/fuse_dev_i.h fs/fuse/inode.c+4 -00 replies
12/32fuse: move request timeout to fuse_chanfs/fuse/dev.c fs/fuse/dev.h fs/fuse/dev_uring.c +5 more+55 -560 replies
13/32fuse: move struct fuse_req and related to fuse_dev_i.hfs/fuse/fuse_dev_i.h fs/fuse/fuse_i.h+90 -920 replies
14/32fuse: don't access transport layer structs directly from the fs layerfs/fuse/control.c fs/fuse/dev.c fs/fuse/dev.h +5 more+124 -550 replies
15/32fuse: move forget related struct and helpersfs/fuse/dev.c fs/fuse/dev.h fs/fuse/dir.c +3 more+29 -290 replies
16/32fuse: move fuse_dev_waitq to dev.cfs/fuse/dev.c fs/fuse/fuse_dev_i.h fs/fuse/inode.c+5 -60 replies
17/32fuse: remove #include "fuse_i.h" from "dev_uring_i.h"fs/fuse/dev.c fs/fuse/dev_uring_i.h fs/fuse/fuse_dev_i.h+17 -140 replies
18/32fuse: remove #include "fuse_i.h" from "req_timeout.c"fs/fuse/dev.h fs/fuse/fuse_i.h fs/fuse/req_timeout.c+3 -30 replies
19/32fuse: abort related layering cleanupfs/fuse/control.c fs/fuse/cuse.c fs/fuse/dev.c +6 more+61 -620 replies
20/32fuse: split off fuse_args and related definitions into a separate headerfs/fuse/args.h fs/fuse/fuse_i.h+66 -522 replies
21/32fuse: remove fm arg of args->end callbackfs/fuse/cuse.c fs/fuse/dev.c fs/fuse/file.c +1 more+22 -240 replies
22/32fuse: change req->fm to req->chanfs/fuse/dev.c fs/fuse/dev_uring.c fs/fuse/fuse_dev_i.h +1 more+69 -730 replies
23/32fuse: split out filesystem part of request sendingfs/fuse/Makefile fs/fuse/dev.c fs/fuse/dev.h +2 more+129 -800 replies
24/32fuse: change fud->fc to fud->chanfs/fuse/cuse.c fs/fuse/dev.c fs/fuse/dev.h +4 more+92 -920 replies
25/32fuse: create poll.cfs/fuse/Makefile fs/fuse/dev.c fs/fuse/dev.h +2 more+158 -1500 replies
26/32fuse: create notify.cfs/fuse/Makefile fs/fuse/dev.c fs/fuse/dev.h +2 more+461 -4460 replies
27/32fuse: set params in fuse_chan_set_initialized()fs/fuse/dev.c fs/fuse/dev.h fs/fuse/dev_uring.c +2 more+44 -172 replies
28/32fuse: remove fuse_mutex protection from fuse_dev_ioctl_sync_init()fs/fuse/dev.c+5 -80 replies
29/32fuse: change ring->fc to ring->chanfs/fuse/dev_uring.c fs/fuse/dev_uring_i.h+22 -240 replies
30/32fuse: remove #include "fuse_i.h" from dev.c and dev_uring.cfs/fuse/backing.c fs/fuse/dev.c fs/fuse/dev.h +4 more+42 -330 replies
31/32fuse: alloc pqueue before installing fch in fuse_devfs/fuse/dev.c fs/fuse/fuse_dev_i.h+59 -191 reply
32/32fuse: simplify fuse_dev_ioctl_clone()fs/fuse/dev.c+17 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/32] fuse: improve transport and fs layer separation

This series is based on fuse-update-7.1 in
git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#for-next

The transport layer encompasses:

- request queuing
- request timeout
- data marshaling
- device I/O

The filesystem layer handles the rest:

- VFS <-> fuse API translation
- caching
- notifications

There are misc functionalities, like tracing and control filesystem, that don't belong to either layer. Also cuse.c and virtio_fs.c still have both transport layer and fs layer parts.

To aid separation, the fields used by the transport layer are split out from struct fuse_conn and added to a new fuse_chan structure.

Transport layer internal headers:

- fuse_dev_i.h
- dev_uring_i.h

Filesystem layer internal header:

- fuse_i.h

Headers describing the API between the layers:

- dev.h
- args.h

Next up: impelement a stripped-down local-only fusex (experimental/ extended) client that can be the base of further work without risking stability of the main one.

---
Miklos Szeredi (32):
fuse: move request timeout code to a new source file
fuse: add struct fuse_chan
fuse: move fuse_iqueue to fuse_chan
fuse: move fuse_dev and fuse_pqueue to dev.c
fuse: move 'devices' member from fuse_conn to fuse_chan
fuse: move background queuing related members to fuse_chan
fuse: move request blocking related members to fuse_chan
fuse: move io_uring related members to fuse_chan
fuse: move interrupt related members to fuse_chan
fuse: split off fch->lock from fc->lock
fuse: add back pointer from fuse_chan to fuse_conn
fuse: move request timeout to fuse_chan
fuse: move struct fuse_req and related to fuse_dev_i.h
fuse: don't access transport layer structs directly from the fs layer
fuse: move forget related struct and helpers
fuse: move fuse_dev_waitq to dev.c
fuse: remove #include "fuse_i.h" from "dev_uring_i.h"
fuse: remove #include "fuse_i.h" from "req_timeout.c"
fuse: abort related layering cleanup
fuse: split off fuse_args and related definitions into a separate
header
fuse: remove fm arg of args->end callback
fuse: change req->fm to req->chan
fuse: split out filesystem part of request sending
fuse: change fud->fc to fud->chan
fuse: create poll.c
fuse: create notify.c
fuse: set params in fuse_chan_set_initialized()
fuse: remove fuse_mutex protection from fuse_dev_ioctl_sync_init()
fuse: change ring->fc to ring->chan
fuse: remove #include "fuse_i.h" from dev.c and dev_uring.c
fuse: alloc pqueue before installing fch in fuse_dev
fuse: simplify fuse_dev_ioctl_clone()

 fs/fuse/Makefile      |    3 +-
 fs/fuse/args.h        |   65 +++
 fs/fuse/backing.c     |    1 +
 fs/fuse/control.c     |   16 +-
 fs/fuse/cuse.c        |   28 +-
 fs/fuse/dev.c         | 1239 +++++++++++++++--------------------------
 fs/fuse/dev.h         |  110 ++++
 fs/fuse/dev_uring.c   |  139 +++--
 fs/fuse/dev_uring_i.h |   37 +-
 fs/fuse/dir.c         |    9 +-
 fs/fuse/file.c        |  146 +----
 fs/fuse/fuse_dev_i.h  |  342 +++++++++++-
 fs/fuse/fuse_i.h      |  412 +-------------
 fs/fuse/fuse_trace.h  |    4 +-
 fs/fuse/inode.c       |  255 ++-------
 fs/fuse/notify.c      |  434 +++++++++++++++
 fs/fuse/poll.c        |  141 +++++
 fs/fuse/req.c         |   99 ++++
 fs/fuse/req_timeout.c |  148 +++++
 fs/fuse/sysctl.c      |    1 +
 fs/fuse/sysctl.h      |    9 +
 fs/fuse/virtio_fs.c   |   21 +-
 22 files changed, 1995 insertions(+), 1664 deletions(-)
 create mode 100644 fs/fuse/args.h
 create mode 100644 fs/fuse/dev.h
 create mode 100644 fs/fuse/notify.c
 create mode 100644 fs/fuse/poll.c
 create mode 100644 fs/fuse/req.c
 create mode 100644 fs/fuse/req_timeout.c
 create mode 100644 fs/fuse/sysctl.h
Signature · 1 line
2.53.0