Skip to content

drm/i915: Eliminate FB usage from low level pinning code

Ville Syrjala intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/xe/fb: Use the correct gtt view for remapped FBsdrivers/gpu/drm/xe/display/xe_fb_pin.c+1 -10 replies
2/11drm/i915: Introduce struct intel_fb_pin_paramsdrivers/gpu/drm/i915/display/intel_fb_pin.h drivers/gpu/drm/i915/display/intel_fbdev.c drivers/gpu/drm/i915/i915_fb_pin.c +2 more+69 -551 reply
3/11drm/i915: Extract intel_fb_needs_cpu_access()drivers/gpu/drm/i915/display/intel_fb.c drivers/gpu/drm/i915/display/intel_fb.h drivers/gpu/drm/i915/i915_fb_pin.c +1 more+8 -21 reply
4/11drm/i915: Introduce pin_params.needs_cpu_lmem_accessdrivers/gpu/drm/i915/display/intel_fb_pin.h drivers/gpu/drm/i915/i915_fb_pin.c drivers/gpu/drm/xe/display/xe_fb_pin.c+6 -23 replies
5/11drm/i915: Extract intel_plane_needs_low_address()drivers/gpu/drm/i915/display/intel_plane.c drivers/gpu/drm/i915/display/intel_plane.h drivers/gpu/drm/i915/i915_fb_pin.c+17 -91 reply
6/11drm/i915: Introduce pin_params.needs_low_addressdrivers/gpu/drm/i915/display/intel_fb_pin.h drivers/gpu/drm/i915/display/intel_fbdev.c drivers/gpu/drm/i915/i915_fb_pin.c+6 -11 reply
7/11drm/i915: Introduce pin_params.needs_physicaldrivers/gpu/drm/i915/display/intel_fb_pin.h drivers/gpu/drm/i915/i915_fb_pin.c+3 -11 reply
8/11drm/i915: Extract intel_plane_needs_fence()drivers/gpu/drm/i915/display/intel_fb.c drivers/gpu/drm/i915/display/intel_plane.c drivers/gpu/drm/i915/display/intel_plane.h +1 more+12 -21 reply
9/11drm/i915: Introduce pin_params.needs_fencedrivers/gpu/drm/i915/display/intel_fb_pin.h drivers/gpu/drm/i915/i915_fb_pin.c+3 -22 replies
10/11drm/xe: Eliminate intel_fb_uses_dpt() call from __xe_pin_fb_vma()drivers/gpu/drm/xe/display/xe_fb_pin.c+5 -41 reply
11/11drm/i915: Don't pass the framebuffer to low level pinning functionsdrivers/gpu/drm/i915/display/intel_fb_pin.h drivers/gpu/drm/i915/display/intel_fbdev.c drivers/gpu/drm/i915/i915_fb_pin.c +2 more+23 -321 reply

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchJani Nikula
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] drm/i915: Eliminate FB usage from low level pinning code

From: Ville Syrjälä <[email protected]>

Some work towards a proper display<->parent fb_pin interface. The goal of the series here is to eliminate display specific things (the fb structure itself, and any display platform checks) from the low level pinning code.

Ville Syrjälä (11):
drm/xe/fb: Use the correct gtt view for remapped FBs drm/i915: Introduce struct intel_fb_pin_params
drm/i915: Extract intel_fb_needs_cpu_access()
drm/i915: Introduce pin_params.needs_cpu_lmem_access drm/i915: Extract intel_plane_needs_low_address() drm/i915: Introduce pin_params.needs_low_address drm/i915: Introduce pin_params.needs_physical
drm/i915: Extract intel_plane_needs_fence()
drm/i915: Introduce pin_params.needs_fence
drm/xe: Eliminate intel_fb_uses_dpt() call from __xe_pin_fb_vma() drm/i915: Don't pass the framebuffer to low level pinning functions

 drivers/gpu/drm/i915/display/intel_fb.c       |  7 +-
 drivers/gpu/drm/i915/display/intel_fb.h       |  1 +
 drivers/gpu/drm/i915/display/intel_fb_pin.h   | 20 +++--
 drivers/gpu/drm/i915/display/intel_fbdev.c    | 19 +++--
 drivers/gpu/drm/i915/display/intel_plane.c    | 22 +++++
 drivers/gpu/drm/i915/display/intel_plane.h    |  3 +
 drivers/gpu/drm/i915/i915_fb_pin.c            | 85 ++++++++++---------
 drivers/gpu/drm/xe/display/xe_fb_pin.c        | 65 +++++++-------
 drivers/gpu/drm/xe/display/xe_initial_plane.c |  6 +-
 9 files changed, 135 insertions(+), 93 deletions(-)
Signature · 1 line
2.52.0