Skip to content

target/mips: Use probe_access_full() in Atomic Load/Store helpers

Philippe Mathieu-Daudé qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 5 repliesIn review
  2. v54 patches 3 repliesSuperseded
  3. v44 patches 7 repliesSuperseded

Changes in v6 from the cover letter

- Remove dead code (rth)
- Reword commit desc (rth)
- Inline translator_ld*

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4target/mips: Pass MemOpIdx argument to Linked Load/Store helperstarget/mips/helper.h target/mips/tcg/ldst_helper.c target/mips/tcg/translate.c+10 -61 reply
2/4target/mips: Inline cpu_ld/st_mmuidx_ra() calls in Atomic LD/ST helperstarget/mips/tcg/ldst_helper.c target/mips/tcg/translate.c+16 -121 reply
3/4target/mips: Inline translator_ld[uw,l,q]() callstarget/mips/tcg/micromips_translate.c.inc target/mips/tcg/mips16e_translate.c.inc target/mips/tcg/nanomips_translate.c.inc +1 more+16 -91 reply
4/4target/mips: Remove last MO_TE usetarget/mips/tcg/mips16e_translate.c.inc+1 -11 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchRichard Henderson
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/4] target/mips: Use probe_access_full() in Atomic Load/Store helpers

Since v5:
- Remove dead code (rth)
- Reword commit desc (rth)
- Inline translator_ld*

Since v4:
- Moved MO_ALIGN change

Following Richard suggestion in [*], use probe_access_full() and replace legacy cpu_ld*_mmuidx_ra() by cpu_ld*_mmu() in Atomic Load/Store helpers.

[*] https://lore.kernel.org/qemu-devel/[email protected]/

Philippe Mathieu-Daudé (4):
target/mips: Pass MemOpIdx argument to Linked Load/Store helpers target/mips: Inline cpu_ld/st_mmuidx_ra() calls in Atomic LD/ST
helpers
target/mips: Inline translator_ld[uw,l,q]() calls target/mips: Remove last MO_TE use

 target/mips/helper.h                      |  4 ++--
 target/mips/tcg/ldst_helper.c             | 27 ++++++++++++++---------
 target/mips/tcg/translate.c               | 19 ++++++++++------
 target/mips/tcg/micromips_translate.c.inc |  2 +-
 target/mips/tcg/mips16e_translate.c.inc   |  8 ++++---
 target/mips/tcg/nanomips_translate.c.inc  |  5 +++--
 6 files changed, 40 insertions(+), 25 deletions(-)
Signature · 1 line
2.53.0