Add migration support to the MSHV accelerator
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest34 patches 19 repliesIn review
Changes since RFC from the cover letter
- Added CET SS/IBT MSR migration
- Assert 64bit padding on CPUX86State->sysenter_cs statically
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/34 | target/i386/mshv: use arch_load/store_reg fnsaccel/ include/ target/ | +23 | 0 replies | |
| 2/34 | target/i386/mshv: use generic FPU/xcr0 stateinclude/ target/ | +47 | 0 replies | |
| 3/34 | target/i386/mshv: impl init/load/store_vcpu_stateaccel/ include/ target/ | +185 | 0 replies | |
| 4/34 | accel/accel-irq: add AccelRouteChange abstractionaccel/ accel/ accel/ +8 more | +41 | 0 replies | |
| 5/34 | accel/accel-irq: add generic begin_route_changesaccel/ hw/ hw/ +4 more | +30 | 0 replies | |
| 6/34 | accel/accel-irq: add generic commit_route_changesaccel/ hw/ hw/ +2 more | +7 | 0 replies | |
| 7/34 | accel/mshv: add irq_routes to stateaccel/ accel/ include/ +1 more | +24 | 0 replies | |
| 8/34 | accel/mshv: update s->irq_routes in add_msi_routeaccel/ accel/ accel/ +1 more | +84 | 0 replies | |
| 9/34 | accel/mshv: update s->irq_routes in update_msi_routeaccel/ | +38 | 0 replies | |
| 10/34 | accel/mshv: update s->irq_routes in release_virqaccel/ accel/ accel/ +1 more | +17 | 0 replies | |
| 11/34 | accel/mshv: use s->irq_routes in commit_routesaccel/ accel/ accel/ +1 more | +7 | 0 replies | |
| 12/34 | accel/mshv: reserve ioapic routes on s->irq_routesaccel/ accel/ include/ | +18 | 0 replies | |
| 13/34 | accel/mshv: remove redundant msi controlleraccel/ accel/ include/ | +0 | 0 replies | |
| 14/34 | target/i386/mshv: move apic logic into own fileinclude/ target/ target/ | +87 | 0 replies | |
| 15/34 | target/i386/mshv: remove redundant apic helperstarget/ | +3 | 0 replies | |
| 16/34 | target/i386/mshv: migrate LAPIC statehw/ include/ target/ | +67 | 10 replies | |
| 17/34 | target/i386/mshv: move msr code to archaccel/ target/ target/ | +1 | 0 replies | |
| 18/34 | accel/mshv: store partition proc featuresaccel/ include/ include/ | +209 | 0 replies | |
| 19/34 | target/i386/mshv: expose msvh_get_generic_regsinclude/ target/ | +8 | 0 replies | |
| 20/34 | target/i386/mshv: migrate MSRsinclude/ include/ target/ +1 more | +259 | 0 replies | |
| 21/34 | target/i386/mshv: migrate MTRR MSRstarget/ | +129 | 0 replies | |
| 22/34 | target/i386/mshv: migrate Synic SINT MSRstarget/ | +41 | 0 replies | |
| 23/34 | target/i386/mshv: migrate CET/SS MSRsinclude/ target/ | +41 | 0 replies | |
| 24/34 | target/i386/mshv: migrate SIMP and SIEFP stateinclude/ target/ target/ +4 more | +260 | 0 replies | |
| 25/34 | target/i386/mshv: migrate STIMER stateinclude/ target/ target/ +2 more | +90 | 0 replies | |
| 26/34 | accel/mshv: introduce SaveVMHandleraccel/ | +75 | 5 replies | |
| 27/34 | accel/mshv: write synthetic MSRs after migrationaccel/ include/ include/ +1 more | +26 | 0 replies | |
| 28/34 | accel/mshv: migrate REFERENCE_TIMEaccel/ | +69 | 0 replies | |
| 29/34 | target/i386/mshv: migrate pending ints/excsinclude/ include/ target/ | +184 | 0 replies | |
| 30/34 | target/i386: add de/compaction to xsave_helpertarget/ target/ | +257 | 3 replies | |
| 31/34 | target/i386/mshv: migrate XSAVE statetarget/ target/ | +100 | 0 replies | |
| 32/34 | target/i386/mshv: reconstruct hflags after loadtarget/ | +13 | 0 replies | |
| 33/34 | target/i386/mshv: migrate MP_STATEaccel/ include/ target/ | +91 | 0 replies | |
| 34/34 | accel/mshv: enable dirty page trackingaccel/ accel/ include/ | +219 | 0 replies |
Reviews trailers per patch
1 of 34 patches has a Reviewed-by or Acked-by.
| Patch | Mohamed Mediouni |
|---|---|
| 1/34 | |
| 2/34 | |
| 3/34 | |
| 4/34 | |
| 5/34 | |
| 6/34 | |
| 7/34 | |
| 8/34 | |
| 9/34 | |
| 10/34 | |
| 11/34 | |
| 12/34 | |
| 13/34 | |
| 14/34 | |
| 15/34 | |
| 16/34 | |
| 17/34 | |
| 18/34 | |
| 19/34 | |
| 20/34 | |
| 21/34 | |
| 22/34 | |
| 23/34 | |
| 24/34 | |
| 25/34 | |
| 26/34 | |
| 27/34 | |
| 28/34 | |
| 29/34 | |
| 30/34 | R-b |
| 31/34 | |
| 32/34 | |
| 33/34 | |
| 34/34 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/34] Add migration support to the MSHV accelerator
Hey all, This is a patch series for live migration support in the MSHV accelerator. Since this is somewhat invasive and touches various parts outside of the accel's folder hierarchies I'm sending an RFC series to collect early feedback.
This patches are sent in sent in isolation, but for LM to be fully functional we will require require the recently submitted patch series "Support QEMU cpu models in MSHV accelerator" (at v6 currently) to be merged, since on some hosts we will need the CPUID infra to disable features that we currently are not able to migrate yet (e.g. AMX tiles).
In this series we perform some preperatory refactorings and introduce new abstractions where required, particulary for irqchips and MSR logic. We also have to introduce some generic logic for XSAVE de/compaction to allow migration of XSAVE state.
Note: there is some pending optimization to avoid a buffer copy and rework existing xsave helper code to be generic over a compacted or standard layout. We'll address this in a later revision or in a discrete patch.
The guest state components that are covered by migration are:
- standard regs
- special regs
- xcr0
- (legacy) FPU regs
- XSAVE
- LAPIC
- MSRs
- SynIC state (SIMP, SIEFP, STIMER)
- pending interrupts/exceptions
- MP state (AP cpu modes)
Finally, routines for dirty-page tracking to reduce migration downtime have beend added and integrated in the respective hooks.
best,
magnus
Changes since RFC:
- Added CET SS/IBT MSR migration
- Assert 64bit padding on CPUX86State->sysenter_cs statically
Magnus Kulke (34):
target/i386/mshv: use arch_load/store_reg fns target/i386/mshv: use generic FPU/xcr0 state target/i386/mshv: impl init/load/store_vcpu_state accel/accel-irq: add AccelRouteChange abstraction accel/accel-irq: add generic begin_route_changes accel/accel-irq: add generic commit_route_changes accel/mshv: add irq_routes to state accel/mshv: update s->irq_routes in add_msi_route accel/mshv: update s->irq_routes in update_msi_route accel/mshv: update s->irq_routes in release_virq accel/mshv: use s->irq_routes in commit_routes accel/mshv: reserve ioapic routes on s->irq_routes accel/mshv: remove redundant msi controller target/i386/mshv: move apic logic into own file target/i386/mshv: remove redundant apic helpers target/i386/mshv: migrate LAPIC state target/i386/mshv: move msr code to arch accel/mshv: store partition proc features target/i386/mshv: expose msvh_get_generic_regs target/i386/mshv: migrate MSRs target/i386/mshv: migrate MTRR MSRs target/i386/mshv: migrate Synic SINT MSRs target/i386/mshv: migrate CET/SS MSRs target/i386/mshv: migrate SIMP and SIEFP state target/i386/mshv: migrate STIMER state accel/mshv: introduce SaveVMHandler accel/mshv: write synthetic MSRs after migration accel/mshv: migrate REFERENCE_TIME target/i386/mshv: migrate pending ints/excs target/i386: add de/compaction to xsave_helper target/i386/mshv: migrate XSAVE state target/i386/mshv: reconstruct hflags after load target/i386/mshv: migrate MP_STATE accel/mshv: enable dirty page tracking
accel/accel-irq.c | 41 +- accel/kvm/kvm-all.c | 6 +- accel/mshv/irq.c | 360 ++++++------ accel/mshv/mem.c | 211 +++++++ accel/mshv/meson.build | 1 - accel/mshv/mshv-all.c | 243 +++++++- accel/mshv/msr.c | 375 ------------- accel/stubs/kvm-stub.c | 2 +- accel/stubs/mshv-stub.c | 6 +- hw/intc/apic_common.c | 3 + hw/misc/ivshmem-pci.c | 8 +- hw/vfio/pci.c | 11 +- hw/virtio/virtio-pci.c | 3 +- include/accel/accel-route.h | 17 + include/hw/hyperv/hvgdk_mini.h | 33 ++ include/hw/hyperv/hvhdk.h | 150 +++++ include/hw/i386/apic_internal.h | 5 + include/system/accel-irq.h | 6 +- include/system/kvm.h | 23 +- include/system/mshv.h | 15 +- include/system/mshv_int.h | 89 +-- target/i386/cpu.h | 14 +- target/i386/kvm/kvm.c | 5 +- target/i386/machine.c | 46 ++ target/i386/mshv/meson.build | 3 + target/i386/mshv/mshv-apic.c | 78 +++ target/i386/mshv/mshv-cpu.c | 958 +++++++++++++++++++++++--------- target/i386/mshv/msr.c | 467 ++++++++++++++++ target/i386/mshv/synic.c | 206 +++++++ target/i386/xsave_helper.c | 255 +++++++++ 30 files changed, 2684 insertions(+), 956 deletions(-) delete mode 100644 accel/mshv/msr.c create mode 100644 include/accel/accel-route.h create mode 100644 target/i386/mshv/mshv-apic.c create mode 100644 target/i386/mshv/msr.c create mode 100644 target/i386/mshv/synic.c
Signature · 1 line
2.34.1