Skip to content

net/bond: fix secondary process crash and related cleanup

Stephen Hemminger dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net/bonding: restore dedicated queue state on mode set errordrivers/net/bonding/rte_eth_bond_8023ad.c+12 -71 reply
2/3net/bonding: prevent crash on Rx/Tx from secondary processdrivers/net/bonding/rte_eth_bond_pmd.c+42 -11 reply
3/3net/bonding: remove redundant function names from logdrivers/net/bonding/rte_eth_bond_api.c drivers/net/bonding/rte_eth_bond_pmd.c+12 -151 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBruce Richardson
SeriesA-b A-b A-b A-b
1/3
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] net/bond: fix secondary process crash and related cleanup

Patch 1 fixes the 8023ad dedicated-queue APIs which ignored the return of bond_ethdev_mode_set() and left the enabled flag inconsistent on failure. Ordered first so the secondary guard added next does not leave shared state corrupted.

Patch 2 fixes the secondary process crash: a bonding port attached in a secondary crashes on the first Rx or Tx burst because the probe path never installs burst functions. Blackhole stubs are installed and mode changes from secondary are rejected. Fully sharing bonding state across processes is out of scope.

Patch 3 drops redundant %s/func from log call sites now that RTE_BOND_LOG supplies the prefix.

Stephen Hemminger (3):
net/bonding: restore dedicated queue state on mode set error net/bonding: prevent crash on Rx/Tx from secondary process net/bonding: remove redundant function names from log

 drivers/net/bonding/rte_eth_bond_8023ad.c | 19 ++++---
 drivers/net/bonding/rte_eth_bond_api.c    |  4 +-
 drivers/net/bonding/rte_eth_bond_pmd.c    | 66 ++++++++++++++++++-----
 3 files changed, 66 insertions(+), 23 deletions(-)
Signature · 1 line
2.53.0