xsk: fix bugs around xsk skb allocation
Status from this message: This series was applied to netdev/net.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest8 patches 10 repliesApplied 8/8
- v48 patches 12 repliesSuperseded
- v38 patches 15 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 8 patches | 18 replies | Superseded | |
| v1 | 4 patches | 9 replies | Superseded |
Patches in v5 All 8 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | xsk: reject sw-csum UMEM binding to IFF_TX_SKB_NO_LINEAR devicesnet/ | +3 | 1 reply | Applied |
| 2/8 | xsk: free the skb when hitting the upper bound MAX_SKB_FRAGSnet/ | +4 | 1 reply | Applied |
| 3/8 | xsk: handle NULL dereference of the skb without frags issuenet/ | +8 | 1 reply | Applied |
| 4/8 | xsk: fix use-after-free of xs->skb in xsk_build_skb() free_err pathnet/ | +1 | 1 reply | Applied |
| 5/8 | xsk: prevent CQ desync when freeing half-built skbs in xsk_build_skb()net/ | +2 | 1 reply | Applied |
| 6/8 | xsk: avoid skb leak in XDP_TX_METADATA casenet/ | +3 | 1 reply | Applied |
| 7/8 | xsk: fix xsk_addrs slab leak on multi-buffer error pathnet/ | +2 | 0 replies | Applied |
| 8/8 | xsk: fix u64 descriptor address truncation on 32-bit architecturesnet/ | +56 | 2 replies | Applied |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Stanislav Fomichev | Alexander Lobakin |
|---|---|---|
| Series | R-b | |
| 1/8 | A-b | |
| 2/8 | A-b | |
| 3/8 | A-b | |
| 4/8 | A-b | |
| 5/8 | A-b | |
| 6/8 | A-b | |
| 7/8 | A-b | |
| 8/8 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net v5 0/8] xsk: fix bugs around xsk skb allocation
From: Jason Xing <[email protected]>
There are rare issues around xsk_build_skb(). Some of them were founded by Sashiko[1][2].
[1]: https://lore.kernel.org/all/[email protected]/
[2]: https://lore.kernel.org/all/[email protected]/
---
v5
1. reword patch 3
2. adjust the order of patch 6 that is now moved up to be patch 2)
3. use helper in patch (Stan)
v4
1. fix 32-bit arch issue in patch 8 (Alexander && Maciej)
2. add acked-by tags (Stan)
v3
1. use !xs->skb as the indicator of first frag in patch 3 (Stan)
2. move init skb after it's allocated successfully, so patch 4,5,6 have been adjusted accordingly (Stan)
3. do not support 32-bit arch (Stan)
4. add acked-by tags (Stan)
v2
1. add four patches spotted by sashiko to fix buggy pre-existing behavior
2. adjust the order of 8 patches.
Jason Xing (8):
xsk: reject sw-csum UMEM binding to IFF_TX_SKB_NO_LINEAR devices
xsk: free the skb when hitting the upper bound MAX_SKB_FRAGS
xsk: handle NULL dereference of the skb without frags issue
xsk: fix use-after-free of xs->skb in xsk_build_skb() free_err path
xsk: prevent CQ desync when freeing half-built skbs in xsk_build_skb()
xsk: avoid skb leak in XDP_TX_METADATA case
xsk: fix xsk_addrs slab leak on multi-buffer error path
xsk: fix u64 descriptor address truncation on 32-bit architectures
net/xdp/xsk.c | 115 ++++++++++++++++++++++++++-------------- net/xdp/xsk_buff_pool.c | 3 ++ 2 files changed, 77 insertions(+), 41 deletions(-)
Signature · 1 line
2.41.3