Skip to content

liveupdate: bug fix for session name and new ioctl to read it

[email protected] kexec linux-mm lkml stable 4 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest4 patches 1 replyApplied
  2. v104 patches 6 repliesSuperseded
  3. v96 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v86 patches12 repliesSuperseded

Patches in v11 Applied

#Subject and filesSizeRepliesApplied
1/4liveupdate: reject LIVEUPDATE_IOCTL_CREATE_SESSION with invalid name lengthkernel/liveupdate/luo_session.c+4 -00 replies
2/4selftests/liveupdate: add test cases for LIVEUPDATE_IOCTL_CREATE_SESSION calls with invalid lengthtools/testing/selftests/liveupdate/liveupdate.c+42 -00 replies
3/4liveupdate: add LIVEUPDATE_SESSION_GET_NAME ioctlinclude/uapi/linux/liveupdate.h kernel/liveupdate/luo_session.c+37 -00 replies
4/4selftests/liveupdate: add test cases for LIVEUPDATE_SESSION_GET_NAMEtools/testing/selftests/liveupdate/liveupdate.c+71 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPasha TatashinPratyush Yadav
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v11 thread

Cover letter [PATCH v11 0/4] liveupdate: bug fix for session name and new ioctl to read it

From: Luca Boccassi <[email protected]>

A series of patches matured while implementing LUO support in userspace in systemd.

- reject session names that are either empty strings or too long
- add new ioctl to retrieve session name from FD, so that userspace can query it without string parsing in procfs

Both changes come with a follow-up patch add test coverage via the existing selftest.

v2: apply one fix from bot review about cleanup on error path:
https://sashiko.dev/#/patchset/20260415184536.1155220-1-luca.boccassi%40gmail.com
the other comments are invalid: luo is not a kmod, and the write hooks are not set up
v3: add test case to liveupdate selftest
v4: split test case in separate follow-up patch
v5: add r-b tag, merge series with LIVEUPDATE_SESSION_GET_NAME ioctl
as they both change the same unit test source file, to avoid merge conflicts add '__u32 reserved' to the UAPI struct
v6: add more test cases as suggested
more verbose commit message
fix docstring
v7: apply suggestion from review bot to stub out setattr ops,
like it was done in 22bdf3d6581a
v8: add new patches to reject session names that are empty or too long
v9: fixes following review comments on LUO_SESSION_MAGIC
v10: split out LUO_SESSION_MAGIC patch as it is undergoing more discussions,
and the other two patches are independent aside from adding test cases to the same unit test source file
v11: rebased on liveupdate/next
reject LIVEUPDATE_SESSION_GET_NAME when 'reserved' is not zero

Luca Boccassi (4):
liveupdate: reject LIVEUPDATE_IOCTL_CREATE_SESSION with invalid name length selftests/liveupdate: add test cases for LIVEUPDATE_IOCTL_CREATE_SESSION calls with invalid length
liveupdate: add LIVEUPDATE_SESSION_GET_NAME ioctl
selftests/liveupdate: add test cases for LIVEUPDATE_SESSION_GET_NAME

 include/uapi/linux/liveupdate.h               |  21 ++++
 kernel/liveupdate/luo_session.c               |  20 ++++
 .../testing/selftests/liveupdate/liveupdate.c | 113 ++++++++++++++++++
 3 files changed, 154 insertions(+)
Signature · 1 line
2.47.3