Skip to content

migration: switch remaining positioned I/O to _all helpers

Junjie Cao qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3migration/qemu-file: switch buffer_at functions to positioned I/O _all helpersmigration/qemu-file.c+3 -320 replies
2/3migration/file: switch file_write_ramblock_iov to pwritev_allmigration/file.c+4 -40 replies
3/3migration/qemu-file: drop incorrect const from qemu_get_buffer_at bufmigration/qemu-file.c migration/qemu-file.h+3 -31 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhilippe Mathieu-DaudéPeter Xu
SeriesR-b
1/3
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] migration: switch remaining positioned I/O to _all helpers

Follow-up to the pread/pwrite_all API series [1].

qemu_put_buffer_at(), qemu_get_buffer_at(), and file_write_ramblock_iov() all use single-shot positioned I/O without retry. They share the same pattern as the bug fixed in multifd_file_recv_data() where a short transfer would be mishandled.

Convert them to the _all helpers and clean up a pre-existing const-correctness issue in qemu_get_buffer_at() along the way.

After this series no positioned I/O call site in migration/ uses raw single-shot channel operations.

Depends-on: <[email protected]> ("io/channel: complete pread/pwrite_all API and fix multifd_file_recv_data")

[1] https://lore.kernel.org/qemu-devel/[email protected]/

Junjie Cao (3):
migration/qemu-file: switch buffer_at functions to positioned I/O _all
helpers
migration/file: switch file_write_ramblock_iov to pwritev_all migration/qemu-file: drop incorrect const from qemu_get_buffer_at buf

 migration/file.c      |  8 ++++----
 migration/qemu-file.c | 37 ++++---------------------------------
 migration/qemu-file.h |  2 +-
 3 files changed, 9 insertions(+), 38 deletions(-)
Signature · 1 line
2.43.0