Skip to content

ASoC: codecs: aw88261: fixes and cleanup

Val Packett linux-sound lkml phone-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 1 replyIn review
  2. v27 patches 7 repliesSuperseded
  3. v12 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- Set default volume to the halfway point
- Restored mute-until-powered-on behavior
- Made TDM slot_width override the hw_params physical_width
- Made set_tdm_slot(0) reset channel mapping to I2S default (L/R == 0/1)
- Pulled T-b tag

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ASoC: codecs: aw88261: support changing sample rate and bit widthsound/soc/codecs/aw88261.c sound/soc/codecs/aw88261.h+299 -640 replies
2/7ASoC: codecs: aw88261: add TDM supportsound/soc/codecs/aw88261.c sound/soc/codecs/aw88261.h+170 -10 replies
3/7ASoC: codecs: aw88261: reduce log spamsound/soc/codecs/aw88261.c+14 -100 replies
4/7ASoC: codecs: aw88261: remove fade in/out on start/stopsound/soc/codecs/aw88261.c sound/soc/codecs/aw88261.h+2 -1590 replies
5/7ASoC: codecs: aw88261: remove async startsound/soc/codecs/aw88261.c sound/soc/codecs/aw88261.h+4 -350 replies
6/7ASoC: codecs: aw88261: fix incorrect masks for boost regssound/soc/codecs/aw88261.c+6 -60 replies
7/7ASoC: codecs: aw88261: make volume control usablesound/soc/codecs/aw88261.c sound/soc/codecs/aw88261.h+23 -230 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by.

PatchLuca Weiss
1/7T-b
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/7] ASoC: codecs: aw88261: fixes and cleanup

The Awinic smart speaker/amp drivers were merged in a very "downstream-brained" state, where configuration was only really determined by the binary "firmware" (register list) file instead of properly participating in the ASoC system. Let's start untangling this mess. This series makes aw88261 actually usable on devices like fairphone-fp5, motorola-dubai and xiaomi-pipa.

v3:
- Set default volume to the halfway point
- Restored mute-until-powered-on behavior
- Made TDM slot_width override the hw_params physical_width
- Made set_tdm_slot(0) reset channel mapping to I2S default (L/R == 0/1)
- Pulled T-b tag

v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/

Val Packett (7):
ASoC: codecs: aw88261: support changing sample rate and bit width
ASoC: codecs: aw88261: add TDM support
ASoC: codecs: aw88261: reduce log spam
ASoC: codecs: aw88261: remove fade in/out on start/stop
ASoC: codecs: aw88261: remove async start
ASoC: codecs: aw88261: fix incorrect masks for boost regs
ASoC: codecs: aw88261: make volume control usable

 sound/soc/codecs/aw88261.c | 627 ++++++++++++++++++++-----------------
 sound/soc/codecs/aw88261.h | 185 ++++++++++-
 2 files changed, 516 insertions(+), 296 deletions(-)
Signature · 1 line
2.53.0