Skip to content

drm/msm: fbdev: Use client buffers

Thomas Zimmermann dri-devel linux-arm-msm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6drm/msm: Do not declare msm_framebuffer_init() as staticdrivers/gpu/drm/msm/msm_drv.h drivers/gpu/drm/msm/msm_fb.c+39 -371 reply
2/6drm/msm: fbdev: Inline msm_alloc_stolen_fb()drivers/gpu/drm/msm/msm_drv.h drivers/gpu/drm/msm/msm_fb.c drivers/gpu/drm/msm/msm_fbdev.c+36 -561 reply
3/6drm/msm: fbdev: Fix error reportingdrivers/gpu/drm/msm/msm_fbdev.c+4 -41 reply
4/6drm/msm: fbdev: Calculate buffer geometry with format helpersdrivers/gpu/drm/msm/msm_drv.h drivers/gpu/drm/msm/msm_fbdev.c+12 -212 replies
5/6drm/msm: fbdev: Use a DRM client bufferdrivers/gpu/drm/msm/msm_fbdev.c+32 -231 reply
6/6drm/msm: Make msm_framebuffer_init() an internal interface againdrivers/gpu/drm/msm/msm_drv.h drivers/gpu/drm/msm/msm_fb.c+4 -81 reply

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchDmitry Baryshkov
1/6R-b
2/6R-b
3/6R-b
4/6
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] drm/msm: fbdev: Use client buffers

A client buffer holds the DRM framebuffer for an in-kernel DRM client. Until now, msm created an internal ad-hoc framebuffer for its fbdev emulation, while by-passing the regular interfaces used by user-space compositors.

Convert msm's fbdev emulation to use client buffers. Replacing the existing code with a client buffer allows for stream-lining msm code and later also the fbdev helpers. The new framebuffer will be registered against the client's file and will support handles for GEM objects. It is then just another framebuffer within the DRM ecosystem.

Patches 1 and 6 change visibility of msm_framebuffer_init() during the refactoring. It is the easiest way to refactor the fbdev probe helper.

Patch 2 and 3 inline the fb allocation code into the fbdev-probe helper and fix it up a bit.

From there patches 4 and 5 convert fbdev buffer allocation to common DRM helpes and client buffers.

If all fbdev emulation helpers can be converted to client buffers, the emulation's whole framebuffer handling could possibly be moved into shared helpers.

Thomas Zimmermann (6):
drm/msm: Do not declare msm_framebuffer_init() as static drm/msm: fbdev: Inline msm_alloc_stolen_fb()
drm/msm: fbdev: Fix error reporting
drm/msm: fbdev: Calculate buffer geometry with format helpers drm/msm: fbdev: Use a DRM client buffer
drm/msm: Make msm_framebuffer_init() an internal interface again

 drivers/gpu/drm/msm/msm_drv.h   |  9 ---
 drivers/gpu/drm/msm/msm_fb.c    | 98 +++++++++------------------------
 drivers/gpu/drm/msm/msm_fbdev.c | 85 +++++++++++++++++++---------
 3 files changed, 85 insertions(+), 107 deletions(-)
Signature · 1 line
2.53.0