Skip to content

Various bug fixes

Jens Axboe io-uring 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6io_uring: fix spurious fput in registered ring pathio_uring/io_uring.c+2 -11 reply
2/6io_uring/rsrc: unify nospec indexing for direct descriptorsio_uring/rsrc.c io_uring/rsrc.h+10 -21 reply
3/6io_uring/rsrc: use kvfree() for the imu cacheio_uring/alloc_cache.h io_uring/rsrc.c+2 -20 replies
4/6io_uring/rw: add defensive hardening for negative kbuf lengthsio_uring/rw.c+2 -21 reply
5/6io_uring/futex: ensure partial wakes are appropriately dequeuedio_uring/futex.c+3 -11 reply
6/6io_uring/register: fix ring resizing with mixed/large SQEs/CQEsio_uring/register.c+28 -81 reply

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchGabriel Krisman Bertazi
1/6R-b
2/6R-b
3/6
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCHSET 0/6] Various bug fixes

Hi,

A random bag of fixes and cleanups. In detail:

- Patch 1, defensive cleanup for a patch merged in this merge window. Not reachable, but it's confusing and should get cleaned up.

- Patch 2, spectre masking for file updates.

- Patch 3, defensive cleanup for the imu cache, using kvfree() consistently. Idea being that it'd be easy to mess this up in the future if caching changes.

- Patch 4, more defensive cleanups, just hardening ensuring that only >= 0 is passed in for bytes consumed for the kbuf path.

- Patch 5, actual fix for futex, where multiple partial wakeups would end up waking the same queue multiple times, rather than moving on to the next one.

- Patch 6, actual fix for ring resizing with CQE32/SQE128 and pending entries in the SQ or CQ rings.

 io_uring/alloc_cache.h |  2 +-
 io_uring/futex.c       |  4 +++-
 io_uring/io_uring.c    |  3 ++-
 io_uring/register.c    | 36 ++++++++++++++++++++++++++++--------
 io_uring/rsrc.c        |  5 ++++-
 io_uring/rsrc.h        |  9 +++++++--
 io_uring/rw.c          |  4 ++--
 7 files changed, 47 insertions(+), 16 deletions(-)
Signature · 1 line
Jens Axboe