netconsole: configfs store callback fixes
Status from this message: This series was applied to netdev/net.git (main)
Get series with b4
b4 am [email protected] change-id 20260422-netconsole_ai_fixes-24599337a79dVersions newest first
- v2 Latest4 patches 0 repliesApplied 4/4
- v13 patches 7 repliesSuperseded
Changes in v2 from the cover letter
- dev_name_store: strip optional trailing newline before length check
so 15-char ifnames written via echo aren't rejected (Simon, Sashiko)
- userdatum_value_store: snapshot and restore udm->value on
update_userdata() failure to keep visible state in sync with the live
payload (Simon/Sashiko)
- Link to v1: https://patch.msgid.link/[email protected]
Patches in v2 All 4 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | netconsole: return count instead of strnlen(buf, count) from store callbacksdrivers/ | +13 | 0 replies | Applied |
| 2/4 | netconsole: avoid clobbering userdatum value on truncated writedrivers/ | +3 | 0 replies | Applied |
| 3/4 | netconsole: propagate device name truncation in dev_name_store()drivers/ | +7 | 0 replies | Applied |
| 4/4 | netconsole: restore userdatum value on update_userdata() failuredrivers/ | +7 | 0 replies | Applied |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by.
| Patch | Simon Horman |
|---|---|
| 1/4 | R-b |
| 2/4 | |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net v2 0/4] netconsole: configfs store callback fixes
V2 for issues in netconsole's configfs store callbacks.
There are still some changes I want to make, such as, having the dynamic lock when reading from configfs (_show() callbacks), wich will solve other issues, but I will keep it for later.
---
Changes in v2:
- dev_name_store: strip optional trailing newline before length check
so 15-char ifnames written via echo aren't rejected (Simon, Sashiko)
- userdatum_value_store: snapshot and restore udm->value on
update_userdata() failure to keep visible state in sync with the live
payload (Simon/Sashiko)
- Link to v1: https://patch.msgid.link/[email protected]
---
Breno Leitao (4):
netconsole: return count instead of strnlen(buf, count) from store callbacks
netconsole: avoid clobbering userdatum value on truncated write
netconsole: propagate device name truncation in dev_name_store()
netconsole: restore userdatum value on update_userdata() failure
drivers/net/netconsole.c | 49 +++++++++++++++++++++++++++++------------------- 1 file changed, 30 insertions(+), 19 deletions(-)
---
base-commit: 7080e32d3f09d8688c4a87d81bdcc71f7f606b16
change-id: 20260422-netconsole_ai_fixes-24599337a79d
Best regards,
Signature · 1 line
Breno Leitao <[email protected]>