Skip to content

bindings: python: modernize C extensions

Vincent Fazio linux-gpio 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 4 repliesApplied
  2. v19 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Dropped "bindings: python: use Py_RETURN_NONE in chip_get_line_name" (Bartosz)
- Adjusted patch 4 to simplify Py_None strong reference acquisition
- Updated link to passing pipeline
- Link to v1: https://lore.kernel.org/all/[email protected]/
---

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/8bindings: python: avoid PyObject_CallMethod during chip finalizebindings/python/gpiod/ext/chip.c+12 -60 replies
2/8bindings: python: avoid PyObject_CallMethod during request finalizebindings/python/gpiod/ext/request.c+12 -60 replies
3/8bindings: python: simplify disallowing _ext.Request from being createdbindings/python/gpiod/ext/request.c+0 -120 replies
4/8bindings: python: use suggestions from upgrade_pythoncapi.pybindings/python/gpiod/ext/chip.c bindings/python/gpiod/ext/common.c bindings/python/gpiod/ext/request.c +1 more+6 -110 replies
5/8bindings: python: use PyImport_ImportModuleAttrString when availablebindings/python/gpiod/ext/common.c bindings/python/gpiod/ext/internal.h+11 -20 replies
6/8bindings: python: migrate the gpiod._ext module to multi-phase initbindings/python/gpiod/ext/module.c+33 -350 replies
7/8bindings: python: tests: migrate the system module to multi-phase initbindings/python/tests/system/ext.c+6 -13 replies
8/8bindings: python: tests: migrate the gpiosim module to multi-phase initbindings/python/tests/gpiosim/ext.c+94 -570 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [libgpiod][PATCH v2 0/8] bindings: python: modernize C extensions

This series performs some minor cleanup of the C extension modules and migrates the module defintions to multi-phase intitialization (PEP 489).

Patches 1 & 2 avoid calling back into python to perform C level object cleanup.

Patch 3 introduces no real functional change but simplifies the code to get the same result.

Patch 4 applies suggestions from from a utility maintained by a CPython core developer to help modernize macro/function usage.

Patch 5 conditionally compiles support for using a standard CPython function over a backported version bundled within the C extension.

Patches 6-8 migrate the C extensions to use multi-phase initialization as described in PEP 489 [0]. While not strictly necessary for enabling free-threaded builds, it makes adding support more straighforward and sets the stage for both PEP 793 [1] which soft-deprecates PyInit_* and PEP 803 [2] which could simplify wheel builds.

Patches have been tested against the full matrix of supported versions:
https://github.com/vfazio/libgpiod/actions/runs/24860932220

[0]: https://peps.python.org/pep-0489/
[1]: https://peps.python.org/pep-0793/
[2]: https://peps.python.org/pep-0803/

---
Changes in v2:
- Dropped "bindings: python: use Py_RETURN_NONE in chip_get_line_name" (Bartosz)
- Adjusted patch 4 to simplify Py_None strong reference acquisition
- Updated link to passing pipeline
- Link to v1: https://lore.kernel.org/all/[email protected]/
---

Vincent Fazio (8):
bindings: python: avoid PyObject_CallMethod during chip finalize
bindings: python: avoid PyObject_CallMethod during request finalize
bindings: python: simplify disallowing _ext.Request from being created
bindings: python: use suggestions from upgrade_pythoncapi.py
bindings: python: use PyImport_ImportModuleAttrString when available
bindings: python: migrate the gpiod._ext module to multi-phase init
bindings: python: tests: migrate the system module to multi-phase init
bindings: python: tests: migrate the gpiosim module to multi-phase
init

 bindings/python/gpiod/ext/chip.c     |  29 ++---
 bindings/python/gpiod/ext/common.c   |   5 +-
 bindings/python/gpiod/ext/internal.h |  10 +-
 bindings/python/gpiod/ext/module.c   |  68 ++++++------
 bindings/python/gpiod/ext/request.c  |  26 ++---
 bindings/python/tests/gpiosim/ext.c  | 153 +++++++++++++++++----------
 bindings/python/tests/system/ext.c   |   7 +-
 7 files changed, 171 insertions(+), 127 deletions(-)
Signature · 1 line
2.43.0