Skip to content

VCE1 fixes (v2)

Timur Kristóf amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/amdgpu: Align amdgpu_gtt_mgr entries to TLB size on Tahitidrivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c+8 -13 replies
2/11drm/amdgpu/vce1: Check that the GPU address is < 128 MiBdrivers/gpu/drm/amd/amdgpu/vce_v1_0.c+8 -41 reply
3/11drm/amdgpu/vce1: Remove superfluous address checkdrivers/gpu/drm/amd/amdgpu/vce_v1_0.c+0 -20 replies
4/11drm/amdgpu/vce1: Check if VRAM address is lower than GART.drivers/gpu/drm/amd/amdgpu/vce_v1_0.c+3 -00 replies
5/11drm/amdgpu/vce1: Don't repeat GTT MGR node allocationdrivers/gpu/drm/amd/amdgpu/vce_v1_0.c+7 -50 replies
6/11drm/amdgpu/vce1: Fix VCE 1 firmware size and offsetsdrivers/gpu/drm/amd/amdgpu/vce_v1_0.c+15 -41 reply
7/11drm/amdgpu/vce1: Stop using amdgpu_vce_resumedrivers/gpu/drm/amd/amdgpu/vce_v1_0.c+6 -101 reply
8/11drm/amdgpu/vce: Check maximum ucode size in amdgpu_vce_resume()drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h drivers/gpu/drm/amd/amdgpu/vce_v2_0.c +2 more+11 -80 replies
9/11drm/amdgpu/vce2: Fix VCE 2 firmware size and offsetsdrivers/gpu/drm/amd/amdgpu/vce_v2_0.c+1 -12 replies
10/11drm/amdgpu/vce3: Fix VCE 3 firmware size and offsetsdrivers/gpu/drm/amd/amdgpu/vce_v3_0.c+1 -11 reply
11/11drm/amdgpu/vce4: Fix VCE 4 firmware size and offsetsdrivers/gpu/drm/amd/amdgpu/vce_v4_0.c+1 -12 replies

Reviews trailers per patch

8 of 11 patches have a Reviewed-by or Acked-by.

PatchChristian König
1/11
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11
9/11R-b
10/11R-b
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] VCE1 fixes (v2)

Fix various small issues regarding VCE1 and the workaround to ensure the VCPU BO has a low 32-bit address.

Also fix an issue around firmware size and offsets on all VCE versions.

Timur Kristóf (11):
drm/amdgpu: Align amdgpu_gtt_mgr entries to TLB size on Tahiti drm/amdgpu/vce1: Check that the GPU address is < 128 MiB drm/amdgpu/vce1: Remove superfluous address check drm/amdgpu/vce1: Check if VRAM address is lower than GART. drm/amdgpu/vce1: Don't repeat GTT MGR node allocation drm/amdgpu/vce1: Fix VCE 1 firmware size and offsets drm/amdgpu/vce1: Stop using amdgpu_vce_resume drm/amdgpu/vce: Check maximum ucode size in amdgpu_vce_resume() drm/amdgpu/vce2: Fix VCE 2 firmware size and offsets drm/amdgpu/vce3: Fix VCE 3 firmware size and offsets drm/amdgpu/vce4: Fix VCE 4 firmware size and offsets

 drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c |  9 ++-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c     |  5 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h     |  2 +-
 drivers/gpu/drm/amd/amdgpu/vce_v1_0.c       | 64 +++++++++++++--------
 drivers/gpu/drm/amd/amdgpu/vce_v2_0.c       |  6 +-
 drivers/gpu/drm/amd/amdgpu/vce_v3_0.c       |  6 +-
 drivers/gpu/drm/amd/amdgpu/vce_v4_0.c       |  6 +-
 7 files changed, 61 insertions(+), 37 deletions(-)
Signature · 1 line
2.53.0