Skip to content

drm/exynos: fbdev: Use client buffers

Thomas Zimmermann dri-devel linux-arm-kernel linux-samsung-soc stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/exynos: fbdev: Remove offset into screen_bufferdrivers/gpu/drm/exynos/exynos_drm_fbdev.c+1 -50 replies
2/5drm/exynos: fbdev: Inline exynos_drm_fbdev_update()drivers/gpu/drm/exynos/exynos_drm_fbdev.c+9 -260 replies
3/5drm/exynos: fbdev: Calculate buffer geometry with format helpersdrivers/gpu/drm/exynos/exynos_drm_fbdev.c+19 -160 replies
4/5drm/exynos: fbdev: Use a DRM client bufferdrivers/gpu/drm/exynos/exynos_drm_fbdev.c+28 -180 replies
5/5drm/exynos: Make exynos_drm_framebuffer_init() an internal interfacedrivers/gpu/drm/exynos/exynos_drm_fb.c drivers/gpu/drm/exynos/exynos_drm_fb.h+1 -82 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarek Szyprowski
SeriesT-b A-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] drm/exynos: fbdev: Use client buffers

A client buffer holds the DRM framebuffer for an in-kernel DRM client. Until now, exynos created an internal ad-hoc framebuffer for its fbdev emulation, while by-passing the regular interfaces used by user-space compositors.

Convert exynos' fbdev emulation to use client buffers. Replacing the existing code with a client buffer allows for stream-lining exynos code and later also the fbdev helpers. The new framebuffer will be registered against the client's file and will support handles for GEM objects. It is then just another framebuffer within the DRM ecosystem.

If all driver's fbdev-emulation helpers can be converted to use client buffers, the emulation's framebuffer handling as a whole can possibly be moved into shared helpers.

Patch 1 first fixes a long-standing bug.

Patches 2 to 4 convert exynos' fbdev emulation to client buffers. It still allocates a GEM object buffer tailored towards fbdev emulation, but size calculations now use common DRM helpers.

Patch 5 cleans up symbol visibility in exynos' fb code.

Thomas Zimmermann (5):
drm/exynos: fbdev: Remove offset into screen_buffer drm/exynos: fbdev: Inline exynos_drm_fbdev_update() drm/exynos: fbdev: Calculate buffer geometry with format helpers drm/exynos: fbdev: Use a DRM client buffer
drm/exynos: Make exynos_drm_framebuffer_init() an internal interface

 drivers/gpu/drm/exynos/exynos_drm_fb.c    |   2 +-
 drivers/gpu/drm/exynos/exynos_drm_fb.h    |   7 --
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 100 ++++++++++------------
 3 files changed, 47 insertions(+), 62 deletions(-)
Signature · 1 line
2.53.0