Skip to content

rtla/tests: Extend runtime test coverage

Tomas Glozar linux-trace-kernel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9rtla/tests: Cover both top and hist tools where possibletools/tracing/rtla/tests/engine.sh tools/tracing/rtla/tests/osnoise.t tools/tracing/rtla/tests/timerlat.t+73 -640 replies
2/9rtla/tests: Add get_workload_pids() helpertools/tracing/rtla/tests/osnoise.t tools/tracing/rtla/tests/scripts/check-priority.sh tools/tracing/rtla/tests/scripts/lib/get_workload_pids.sh +1 more+17 -60 replies
3/9rtla/tests: Check -c/--cpus thread affinitytools/tracing/rtla/tests/osnoise.t tools/tracing/rtla/tests/scripts/check-cpus.sh tools/tracing/rtla/tests/timerlat.t+13 -20 replies
4/9rtla/tests: Use negative match when testing --aa-onlytools/tracing/rtla/tests/timerlat.t+1 -10 replies
5/9rtla/tests: Extend timerlat top --aa-only coveragetools/tracing/rtla/tests/timerlat.t+4 -20 replies
6/9rtla/tests: Cover all hist options in runtime teststools/tracing/rtla/tests/osnoise.t tools/tracing/rtla/tests/timerlat.t+36 -20 replies
7/9rtla/tests: Add runtime test for -H/--house-keepingtools/tracing/rtla/tests/osnoise.t tools/tracing/rtla/tests/scripts/check-housekeeping-cpus.sh tools/tracing/rtla/tests/timerlat.t+8 -00 replies
8/9rtla/tests: Add runtime test for -k and -u optionstools/tracing/rtla/tests/osnoise.t tools/tracing/rtla/tests/scripts/check-user-kernel-threads.sh tools/tracing/rtla/tests/timerlat.t+30 -60 replies
9/9rtla/tests: Add runtime tests for -C/--cgrouptools/tracing/rtla/tests/osnoise.t tools/tracing/rtla/tests/scripts/check-cgroup-match.sh tools/tracing/rtla/tests/timerlat.t+23 -00 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchWander Lairson Costa
SeriesR-b
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] rtla/tests: Extend runtime test coverage

This patchset introduces some new tests to cover more options, especially histogram and thread options. Most of the new tests use positive and negative output matches, sometimes in combination with action scripts, to verify that RTLA is applying the settings correctly.

Tests were reorganized a little, adding two new sections: thread tests and histogram tests, next to basic tests.

Additionally, coverage of existing tests is extended by adding new matches and by extending tests to cover both top and hist tools where possible. For the latter, new helpers check_top_hist and check_top_q_hist are added to engine.sh.

As part of the new action scripts, detection of measurement threads is made more robust by following child processes of either RTLA (user workload) or kthreadd (kernel workload) rather than grepping through the comms of all processes, which might have lead to false positives.

These changes significantly improve test coverage and make the test suite more against false positives from unrelated processes.

Tomas Glozar (9):
rtla/tests: Cover both top and hist tools where possible rtla/tests: Add get_workload_pids() helper rtla/tests: Check -c/--cpus thread affinity rtla/tests: Use negative match when testing --aa-only rtla/tests: Extend timerlat top --aa-only coverage rtla/tests: Cover all hist options in runtime tests rtla/tests: Add runtime test for -H/--house-keeping rtla/tests: Add runtime test for -k and -u options rtla/tests: Add runtime tests for -C/--cgroup

 tools/tracing/rtla/tests/engine.sh            |  15 +++
 tools/tracing/rtla/tests/osnoise.t            |  73 +++++++----
 .../rtla/tests/scripts/check-cgroup-match.sh  |  17 +++
 .../tracing/rtla/tests/scripts/check-cpus.sh  |   9 ++
 .../tests/scripts/check-housekeeping-cpus.sh  |   4 +
 .../rtla/tests/scripts/check-priority.sh      |   8 +-
 .../scripts/check-user-kernel-threads.sh      |  16 +++
 .../tests/scripts/lib/get_workload_pids.sh    |  11 ++
 tools/tracing/rtla/tests/timerlat.t           | 113 +++++++++++-------
 9 files changed, 194 insertions(+), 72 deletions(-)
 create mode 100755 tools/tracing/rtla/tests/scripts/check-cgroup-match.sh
 create mode 100755 tools/tracing/rtla/tests/scripts/check-cpus.sh
 create mode 100755 tools/tracing/rtla/tests/scripts/check-housekeeping-cpus.sh
 create mode 100755 tools/tracing/rtla/tests/scripts/check-user-kernel-threads.sh
 create mode 100644 tools/tracing/rtla/tests/scripts/lib/get_workload_pids.sh
Signature · 1 line
2.53.0