Skip to content

target/s390x/tcg: Compile various files once

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9tcg: Include missing 'tcg/tcg-op-common.h' header in 'tcg-op-mem.h'include/tcg/tcg-op-mem.h+2 -03 replies
2/9target/s390x: Do not compile KVM stubs for linux-user binarytarget/s390x/kvm/meson.build+1 -11 reply
3/9target/s390x: Introduce common system/user meson source settarget/s390x/meson.build+13 -121 reply
4/9target/s390x: Compile few files as common unittarget/s390x/tcg/meson.build+6 -41 reply
5/9target/s390x: Compile translate.c as common unittarget/s390x/tcg/meson.build target/s390x/tcg/translate.c+5 -31 reply
6/9target/s390x: Compile vec_helper.c as common unittarget/s390x/tcg/meson.build target/s390x/tcg/vec_helper.c+24 -122 replies
7/9target/s390x: Have MSA helper pass a mmu_idx argumenttarget/s390x/tcg/crypto_helper.c+22 -191 reply
8/9target/s390x: Compile crypto_helper.c as common unittarget/s390x/tcg/crypto_helper.c target/s390x/tcg/meson.build+22 -191 reply
9/9target/s390x: Replace cpu_stb_data_ra -> cpu_stb_mmu in STFLE opcodetarget/s390x/tcg/misc_helper.c+5 -21 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchIlya Leoshkevich
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] target/s390x/tcg: Compile various files once

When a file doesn't use any target-specific knowledge, it can be compiled once as common object. By moving the file to a meson 'common' source set, we ensure no target-specific API will be ever used [*]. This series move early few s390x TCG files to common because in the current state it is cheap enough to do so, no need to procrastinate.

[*] https://lore.kernel.org/qemu-devel/[email protected]/

Philippe Mathieu-Daudé (9):
tcg: Include missing 'tcg/tcg-op-common.h' header in 'tcg-op-mem.h' target/s390x: Do not compile KVM stubs for linux-user binary target/s390x: Introduce common system/user meson source set target/s390x: Compile few files as common unit target/s390x: Compile translate.c as common unit target/s390x: Compile vec_helper.c as common unit target/s390x: Have MSA helper pass a mmu_idx argument target/s390x: Compile crypto_helper.c as common unit target/s390x: Replace cpu_stb_data_ra -> cpu_stb_mmu in STFLE opcode

 include/tcg/tcg-op-mem.h         |  2 +
 target/s390x/tcg/crypto_helper.c | 80 +++++++++++++++++---------------
 target/s390x/tcg/misc_helper.c   |  7 ++-
 target/s390x/tcg/translate.c     |  6 ++-
 target/s390x/tcg/vec_helper.c    | 34 +++++++++-----
 target/s390x/kvm/meson.build     |  2 +-
 target/s390x/meson.build         | 25 +++++-----
 target/s390x/tcg/meson.build     |  8 ++--
 8 files changed, 96 insertions(+), 68 deletions(-)
Signature · 1 line
2.53.0