Netfilter/IPVS fixes for net
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest11 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | netfilter: arp_tables: fix IEEE1394 ARP payload parsingnet/ net/ | +23 | 0 replies | |
| 2/11 | netfilter: nf_tables: use list_del_rcu for netlink hooksnet/ | +18 | 0 replies | |
| 3/11 | rculist: add list_splice_rcu() for private listsinclude/ | +29 | 0 replies | |
| 4/11 | netfilter: nf_tables: join hook list via splice_list_rcu() in commit phasenet/ | +4 | 0 replies | |
| 5/11 | netfilter: nf_tables: add hook transactions for device deletionsinclude/ net/ | +217 | 0 replies | |
| 6/11 | netfilter: xt_policy: fix strict mode inbound policy matchingnet/ | +1 | 0 replies | |
| 7/11 | netfilter: reject zero shift in nft_bitwisenet/ | +2 | 0 replies | |
| 8/11 | netfilter: nf_conntrack_sip: don't use simple_strtoulnet/ net/ | +119 | 0 replies | |
| 9/11 | ipvs: fixes for the new ip_vs_status infonet/ | +36 | 0 replies | |
| 10/11 | ipvs: fix races around the conn_lfactor and svc_lfactor sysctl varsnet/ net/ | +10 | 0 replies | |
| 11/11 | ipvs: fix the spin_lock usage for RT buildnet/ | +36 | 4 replies |
Reviews trailers per patch
3 of 11 patches have a Reviewed-by or Acked-by.
| Patch | Paul E. McKenney | Florian Westphal | Fernando Fernandez Mancera |
|---|---|---|---|
| 1/11 | |||
| 2/11 | |||
| 3/11 | R-b | ||
| 4/11 | |||
| 5/11 | |||
| 6/11 | A-b | ||
| 7/11 | R-b | ||
| 8/11 | |||
| 9/11 | |||
| 10/11 | |||
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH net 00/11] Netfilter/IPVS fixes for net
Hi,
The following patchset contains Netfilter/IPVS fixes for net:
1) IEEE1394 ARP payload contains no target hardware address in the ARP packet. Apparently, arp_tables was never updated to deal with IEEE1394 ARP properly. To deal with this, return no match in case the target hardware address selector is used, either for inverse or normal match. Moreover, arpt_mangle disallows mangling of the target hardware and IP address because, it is not worth to adjust the offset calculation to fix this, we suspect no users of arp_tables for this family.
2) Use list_del_rcu() to delete device hooks in nf_tables, this hook list is RCU protected, concurrent netlink dump readers can be walking on this list, fix it by adding a helper function and use it for consistency. From Florian Westphal.
3) Add list_splice_rcu(), this is useful for joining the local list of new device hooks to the RCU protected hook list in chain and flowtable. Reviewed by Paul E. McKenney.
4) Use list_splice_rcu() to publish the new device hooks in chain and flowtable to fix concurrent netlink dump traversal.
5) Add a new hook transaction object to track device hook deletions. The current approach moves device hooks to be deleted around during the preparation phase, this breaks concurrent RCU reader via netlink dump. This new hook transaction is combined with NFT_HOOK_REMOVE flag to annotate hooks for removal in the preparation phase.
6) xt_policy inbound policy check in strict mode can lead to out-of-bound access of the secpath array due to incorrect. The iteration over the secpath needs to be reversed in the inbound to check for the human readable policy, expecting inner in first position and outer in second position, the secpath from inbound actually stores outer in first position then in second position. From Jiexun Wang.
7) Fix possible zero shift in nft_bitwise triggering UBSAN splat, reject zero shift from control plane, from Kai Ma.
8) Replace simple_strtoul() in the conntrack SIP helper since it relies on nul-terminated strings. From Florian Westphal.
The IPVS fixes for recent net-next updates, from Julian Anastasov:
9) Fix several issues in the new /proc/net/ip_vs_status interface:
prevent use-after-free by properly updating svc_table_changes during service deletion/flushing; bound bucket traversal and add loop detection to prevent infinite loops and overflows; use div_u64 for safer 32-bit math; and restrict file permissions to 0440 to protect hash distribution info from non-root users.
10) Fix a race condition between the sysctl interface and the teardown of IPVS hash tables. Specifically, it prevents the system from trying to schedulework on a table that has already been destroyed.
11) Fix sleeping function called from invalid context bug. On RT kernels, standard spinlocks can sleep, but "bit locks" (used by the new hash table) do not. Holding a sleeping lock while a non-sleeping bit lock is held is illegal.
Please, pull these changes from:
git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git nf-26-04-24
Thanks.
----------------------------------------------------------------
The following changes since commit 711987ba281fd806322a7cd244e98e2a81903114:
netfilter: nfnetlink_osf: fix potential NULL dereference in ttl check (2026-04-20 23:45:44 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git tags/nf-26-04-24
for you to fetch changes up to b51edb039b1dbcdc83e00c31cf5887bd75486dcc:
ipvs: fix the spin_lock usage for RT build (2026-04-24 20:09:57 +0200)
----------------------------------------------------------------
netfilter pull request 26-04-24
----------------------------------------------------------------
Florian Westphal (2):
netfilter: nf_tables: use list_del_rcu for netlink hooks
netfilter: nf_conntrack_sip: don't use simple_strtoul
Jiexun Wang (1):
netfilter: xt_policy: fix strict mode inbound policy matching
Julian Anastasov (3):
ipvs: fixes for the new ip_vs_status info
ipvs: fix races around the conn_lfactor and svc_lfactor sysctl vars
ipvs: fix the spin_lock usage for RT build
Kai Ma (1):
netfilter: reject zero shift in nft_bitwise
Pablo Neira Ayuso (4):
netfilter: arp_tables: fix IEEE1394 ARP payload parsing
rculist: add list_splice_rcu() for private lists
netfilter: nf_tables: join hook list via splice_list_rcu() in commit phase
netfilter: nf_tables: add hook transactions for device deletions
include/linux/rculist.h | 29 ++++ include/net/netfilter/nf_tables.h | 13 ++ net/ipv4/netfilter/arp_tables.c | 18 ++- net/ipv4/netfilter/arpt_mangle.c | 8 + net/netfilter/ipvs/ip_vs_conn.c | 71 ++++----- net/netfilter/ipvs/ip_vs_ctl.c | 63 +++++--- net/netfilter/nf_conntrack_sip.c | 152 +++++++++++++----- net/netfilter/nf_nat_sip.c | 1 + net/netfilter/nf_tables_api.c | 314 +++++++++++++++++++++++++++----------- net/netfilter/nft_bitwise.c | 3 +- net/netfilter/xt_policy.c | 2 +- 11 files changed, 494 insertions(+), 180 deletions(-)