Skip to content

Lenovo Yoga Book 9 keyboard dock detection

Dave Carey linux-input lkml platform-driver-x86 16 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v15 Latest2 patches 1 replyIn review
  2. v142 patches 2 repliesSuperseded
  3. v132 patches 2 repliesSuperseded
Earlier versions · 13
VersionPostedPatchesRepliesStatus
v12 posting 2/22 patches1 replySuperseded
v12 posting 1/22 patches2 repliesSuperseded
v112 patches1 replySuperseded
v102 patches1 replySuperseded
v92 patches1 replySuperseded
v82 patches4 repliesSuperseded
v72 patches3 repliesSuperseded
v62 patches5 repliesSuperseded
v51 patch5 repliesSuperseded
v41 patch2 repliesSuperseded
v31 patch0 repliesSuperseded
v21 patch0 repliesSuperseded
v11 patch2 repliesSuperseded

Changes in v15 from the cover letter

- yb9_kbdock_notify_new(): restore .min_event_size = sizeof(__le32) in struct wmi_driver and remove the manual buffer-length check; the .min_event_size field was present in v12/v13 (added in v10) but was accidentally dropped in v14.

Patches in v15 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2platform/x86/lenovo: lenovo-ymc: Suppress probe on Yoga Book 9 14IAH10drivers/platform/x86/lenovo/ymc.c+19 -00 replies
2/2platform/x86/lenovo: Add Yoga Book 9 keyboard dock detection driverDocumentation/ABI/testing/sysfs-driver-lenovo-yb9-kbdock MAINTAINERS drivers/platform/x86/lenovo/Kconfig +2 more+364 -00 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchHans de GoedeArmin Wolf
1/2
2/2A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v15 thread

Cover letter [PATCH v15 0/2] Lenovo Yoga Book 9 keyboard dock detection

Changes in v15 (addressing Ilpo Järvinen's v14 review of patch 2/2):

- yb9_kbdock_notify_new(): restore .min_event_size = sizeof(__le32) in struct wmi_driver and remove the manual buffer-length check; the .min_event_size field was present in v12/v13 (added in v10) but was accidentally dropped in v14.

Patch 1/2 (lenovo-ymc) is unchanged from v10.

Changes in v14 (addressing Ilpo Järvinen's v13 review of patch 2/2):

- Restore #include <linux/compiler_attributes.h> and <linux/spinlock.h>, which were accidentally absent from v13.
- Restore spinlock_t lock in struct yb9_kbdock_data, spin_lock_init(), and spin_lock/spin_unlock around input_report_switch + input_sync in yb9_kbdock_report().
- Restore pointer-out yb9_kbdock_query(d, u32 *bkbd) and removal of zero-initializer from struct wmi_buffer out.
- Restore int return from yb9_kbdock_sync() and error propagation in yb9_kbdock_resume() and yb9_kbdock_block_probe().

Changes in v13:

- Resend of v12: v12 was corrupted in transit. Root cause: the ABI documentation uses RST table separator lines (== ====...) which contain '=' characters; git-send-email selected quoted-printable transfer encoding due to non-ASCII in the changelog (UTF-8 author name), encoding '=' as '=3D' and breaking git-am on the receiving end. Fixed by setting sendemail.transferEncoding=8bit. No content changes from v12.

Changes in v12 (addressing Ilpo Järvinen's v11 review of patch 2/2):

- Add #include <linux/sysfs.h> (for sysfs_emit)
- Add #include <linux/types.h> (for __le32 and __packed)

Changes in v11 (addressing Armin Wolf's v10 review of patch 2/2):

- ABI doc: correct Date to "June 2027" and KernelVersion to "7.3"; these fields should reflect when the ABI lands in the kernel, not the submission date.

Patch 1/2 (lenovo-ymc) is unchanged from v10.

Changes in v10 (addressing Armin Wolf's v9 review of patch 2/2):

- Update ABI doc: Date: June 2026, KernelVersion: 6.16
- Add #include <linux/compiler_attributes.h> and <linux/types.h>
- yb9_kbdock_query(): change return to pointer-out u32 *bkbd to avoid

    a 0xFFFFFFFF status value being misread as -EPERM

- struct yb9_kbdock_data: add spinlock_t lock
- yb9_kbdock_report(): hold lock across input_report_switch + input_sync
- yb9_kbdock_sync(): return int, propagate query error to callers
- yb9_kbdock_resume(), yb9_kbdock_block_probe(): propagate sync error
- struct wmi_buffer out: remove zero-initializer (not needed)
- yb9_kbdock_notify_new(): drop manual length check; use .min_event_size = sizeof(__le32) in struct wmi_driver instead

Patch 1/2 (lenovo-ymc) is unchanged from v9.

Dave Carey (2):
platform/x86/lenovo: lenovo-ymc: Suppress probe on Yoga Book 9 14IAH10 platform/x86/lenovo: Add Yoga Book 9 keyboard dock detection driver

 Documentation/ABI/testing/sysfs-driver-lenovo-yb9-kbdock |  19 ++
 MAINTAINERS                                               |   7 +
 drivers/platform/x86/lenovo/Kconfig                       |  14 +
 drivers/platform/x86/lenovo/Makefile                      |   1 +
 drivers/platform/x86/lenovo/yb9-kbdock.c                  | 323 ++++++++++++
 drivers/platform/x86/lenovo/ymc.c                         |  19 ++
 6 files changed, 383 insertions(+)

2.55.0