Skip to content

bridge: mcast: Fix a false positive lockdep splat

Ido Schimmel bridge netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyApplied 2/2
  2. v21 patch 1 replySuperseded
  3. v11 patch 3 repliesSuperseded

Changes in v3 from the cover letter

- Use skb_queue_splice_tail_init() (Eric).
- Increment multicast stats from the workqueue.
- Add patch #2.
- Target at net-next.

Patches in v3 All 2 applied

#Subject and filesSizeRepliesApplied
1/2bridge: mcast: Fix a false positive lockdep splatnet/bridge/br_multicast.c net/bridge/br_private.h+83 -81 replyApplied
2/2bridge: mcast: Remove unnecessary argument from br_multicast_alloc_query()net/bridge/br_multicast.c+6 -120 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPetr MachataNikolay Aleksandrov
1/2R-b A-b
2/2R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/2] bridge: mcast: Fix a false positive lockdep splat

Patch #1 fixes false positive lockdep splat. See the commit message for more details.

Patch #2 is small cleanup following the previous patch.

Targeting at net-next since this is a false positive that is only visible with lockdep enabled and the change is not small / trivial.

v3:
- Use skb_queue_splice_tail_init() (Eric).
- Increment multicast stats from the workqueue.
- Add patch #2.
- Target at net-next.

v2: https://lore.kernel.org/netdev/[email protected]/
- Limit the queue to 1,000 skbs.
- Edit the trace to avoid checkpatch errors.

v1: https://lore.kernel.org/netdev/[email protected]/

Ido Schimmel (2):
bridge: mcast: Fix a false positive lockdep splat
bridge: mcast: Remove unnecessary argument from
br_multicast_alloc_query()

 net/bridge/br_multicast.c | 105 ++++++++++++++++++++++++++++++--------
 net/bridge/br_private.h   |   4 ++
 2 files changed, 89 insertions(+), 20 deletions(-)
Signature · 1 line
2.54.0