Skip to content

Improvements to PCI hibernate path

Mario Limonciello (AMD) linux-pci linux-pm lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 10 repliesIn review
  2. v15 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Include Lukas' patch from pci/pm directly in series so Sashiko can better review.
- Include linux-pm in CC.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6PCI: Stop setting cached power state to "unknown" on unbinddrivers/pci/pci-driver.c+2 -81 reply
2/6PCI/PM: Disable device wakeups when halting or powering off systemdrivers/pci/pci-driver.c+3 -01 reply
3/6PCI/PM: Split out code from pci_pm_suspend_noirq() into helperdrivers/pci/pci-driver.c+54 -321 reply
4/6PCI/PM: Run bridge power up actions as part of restore phasedrivers/pci/pci-driver.c+5 -01 reply
5/6PCI/PM: Use pci_power_manageable() in pci_pm_poweroff_noirq()drivers/pci/pci-driver.c+1 -11 reply
6/6PCI: Put PCIe bridges with downstream devices into D3 at hibernatedrivers/pci/pci-driver.c+9 -41 reply

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchMario Limonciello (AMD)Eric NaimRafael J. Wysocki (Intel)
1/6R-b R-b
2/6T-b
3/6T-b
4/6T-b
5/6T-b
6/6T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/6] Improvements to PCI hibernate path

A few cycles ago I sent out a kernel series for using the S4 paths when the system goes to S5. Some parts of it got merged, and Rafael suggested to split the other parts into smaller pieces across multiple kernel cycles to make bisecting easier.

This fell into my backlog behind other things, so I wanted to try again this cycle for the PCI pieces. I have been carrying it, rebasing it and personally using it for a while now though.

This series attempts to unify the PCI suspend and hibernate paths and to fix some things that I observed to be wrong with how I expect hibernate to work.

Based off v7.1-rc1

v2:
- Include Lukas' patch from pci/pm directly in series so Sashiko can better review.
- Include linux-pm in CC.

Lukas Wunner (1):
PCI: Stop setting cached power state to "unknown" on unbind

Mario Limonciello (AMD) (5):
PCI/PM: Disable device wakeups when halting or powering off system PCI/PM: Split out code from pci_pm_suspend_noirq() into helper PCI/PM: Run bridge power up actions as part of restore phase PCI/PM: Use pci_power_manageable() in pci_pm_poweroff_noirq()
PCI: Put PCIe bridges with downstream devices into D3 at hibernate

 drivers/pci/pci-driver.c | 109 +++++++++++++++++++++++++--------------
 1 file changed, 69 insertions(+), 40 deletions(-)
Signature · 1 line
2.53.0