Skip to content

Improve SDCA support for duplicated features

Charles Keepax linux-sound lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v23 patches 2 repliesSuperseded
  3. v13 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Add missing set of desc pointer in tas2783 from v1
- Minor reordering in sdca_jack_set_jack

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ASoC: SDCA: Add correct masks whilst reporting SDCA jack statusinclude/sound/sdca_jack.h sound/soc/sdca/sdca_jack.c+47 -310 replies
2/3ASoC: SDCA: Remove sdca_function_data duplicationinclude/sound/sdca_function.h sound/soc/codecs/tas2783-sdw.c sound/soc/sdca/sdca_class.c +3 more+18 -450 replies
3/3ASoC: SDCA: Support devices with multiple functions of identical typeinclude/sound/sdca.h sound/soc/sdca/sdca_functions.c sound/soc/sdca/sdca_interrupts.c+29 -40 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPierre-Louis Bossart
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] Improve SDCA support for duplicated features

There are some short comings of the current SDCA class driver with respect to duplicated functions and jacks. Fix some issues in the reporting of jacks when there are multiple jacks represented in the SDCA topology. When a single device contains multiple instances of the same type of SDCA function the current class driver will create duplicate controls, update the code to fix this. Finally whilst working through this also tidy up the handling of the sdca_function_desc pointers as it turns out some duplication has crept into the code on that front.

Thanks,
Charles

Changes since v2:
- Add missing set of desc pointer in tas2783 from v1
- Minor reordering in sdca_jack_set_jack

Changes since v1:
- Update tas2783 for API changes
- Correct kernel doc

Charles Keepax (3):
ASoC: SDCA: Add correct masks whilst reporting SDCA jack status
ASoC: SDCA: Remove sdca_function_data duplication
ASoC: SDCA: Support devices with multiple functions of identical type

 include/sound/sdca.h                 |  4 ++
 include/sound/sdca_function.h        |  1 -
 include/sound/sdca_jack.h            |  3 ++
 sound/soc/codecs/tas2783-sdw.c       |  6 +--
 sound/soc/sdca/sdca_class.c          |  7 ---
 sound/soc/sdca/sdca_class.h          |  1 -
 sound/soc/sdca/sdca_class_function.c | 23 ++-------
 sound/soc/sdca/sdca_functions.c      | 51 ++++++++++++-------
 sound/soc/sdca/sdca_interrupts.c     |  3 +-
 sound/soc/sdca/sdca_jack.c           | 75 ++++++++++++++++------------
 10 files changed, 94 insertions(+), 80 deletions(-)
Signature · 1 line
2.47.3