Skip to content

staging: octeon: remove typedefs for enums and structs

Eric Wu linux-mips linux-staging lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7staging: octeon: convert cvmx_spi_mode_t from typedef to plain enumarch/mips/cavium-octeon/executive/cvmx-spi.c arch/mips/include/asm/octeon/cvmx-spi.h drivers/staging/octeon/octeon-stubs.h+30 -300 replies
2/7staging: octeon: convert cvmx_helper_interface_mode_t from typedef to plain enumarch/mips/cavium-octeon/executive/cvmx-helper-util.c arch/mips/cavium-octeon/executive/cvmx-helper.c arch/mips/cavium-octeon/executive/cvmx-pko.c +4 more+14 -140 replies
3/7staging: octeon: convert cvmx_pow_wait_t from typedef to plain enumarch/mips/include/asm/octeon/cvmx-pow.h drivers/staging/octeon/octeon-stubs.h+11 -110 replies
4/7staging: octeon: convert cvmx_pko_lock_t from typedef to plain enumarch/mips/include/asm/octeon/cvmx-pko.h drivers/staging/octeon/octeon-stubs.h+9 -90 replies
5/7staging: octeon: convert cvmx_pko_status_t from typedef to plain enumarch/mips/cavium-octeon/executive/cvmx-pko.c arch/mips/include/asm/octeon/cvmx-pko.h drivers/staging/octeon/octeon-stubs.h+10 -100 replies
6/7staging: octeon: convert cvmx_pko_port_status_t from typedef to plain structarch/mips/include/asm/octeon/cvmx-pko.h drivers/staging/octeon/ethernet.c drivers/staging/octeon/octeon-stubs.h+7 -70 replies
7/7staging: octeon: convert cvmx_pip_port_status_t from typedef to plain structarch/mips/include/asm/octeon/cvmx-pip.h drivers/staging/octeon/ethernet.c drivers/staging/octeon/octeon-stubs.h+7 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] staging: octeon: remove typedefs for enums and structs

The staging octeon driver's TODO list includes "general code review and clean up". This series addresses that by removing unnecessary typedefs for enums and structs, converting them to plain types as required by the Linux kernel coding style (Documentation/process/coding-style.rst, section 5).

All typedefs ending in _t have been removed from the staging driver stubs (drivers/staging/octeon/octeon-stubs.h) and correspondingly updated in the arch/mips/ implementation headers and source files.

The series converts:
- 5 enum typedefs to plain enums:
cvmx_spi_mode_t, cvmx_helper_interface_mode_t, cvmx_pow_wait_t, cvmx_pko_lock_t, cvmx_pko_status_t
- 2 struct typedefs to plain structs:
cvmx_pko_port_status_t, cvmx_pip_port_status_t

No functional change intended. All patches have been compile-tested for both MIPS (cavium_octeon_defconfig) and x86_64 (with CONFIG_STAGING=y, CONFIG_OCTEON_ETHERNET=y, CONFIG_COMPILE_TEST=y).

Eric Wu (7):
staging: octeon: convert cvmx_spi_mode_t from typedef to plain enum
staging: octeon: convert cvmx_helper_interface_mode_t from typedef to
plain enum
staging: octeon: convert cvmx_pow_wait_t from typedef to plain enum
staging: octeon: convert cvmx_pko_lock_t from typedef to plain enum
staging: octeon: convert cvmx_pko_status_t from typedef to plain enum
staging: octeon: convert cvmx_pko_port_status_t from typedef to plain
struct
staging: octeon: convert cvmx_pip_port_status_t from typedef to plain
struct

 .../executive/cvmx-helper-util.c              |  2 +-
 .../cavium-octeon/executive/cvmx-helper.c     |  8 ++--
 arch/mips/cavium-octeon/executive/cvmx-pko.c  |  6 +--
 arch/mips/cavium-octeon/executive/cvmx-spi.c  | 16 +++----
 .../include/asm/octeon/cvmx-helper-util.h     |  2 +-
 arch/mips/include/asm/octeon/cvmx-helper.h    |  6 +--
 arch/mips/include/asm/octeon/cvmx-pip.h       |  6 +--
 arch/mips/include/asm/octeon/cvmx-pko.h       | 26 +++++-----
 arch/mips/include/asm/octeon/cvmx-pow.h       | 12 ++---
 arch/mips/include/asm/octeon/cvmx-spi.h       | 38 +++++++--------
 drivers/staging/octeon/ethernet.c             |  6 +--
 drivers/staging/octeon/octeon-stubs.h         | 48 +++++++++----------
 12 files changed, 88 insertions(+), 88 deletions(-)
Signature · 1 line
2.43.0