Skip to content

bpf: Extend the bpf_list family of APIs

Kaitao Cheng bpf linux-doc linux-kselftest lkml sashiko-reviews 3 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest8 patches 4 repliesApplied 8/8
  2. v10 posting 2/28 patches 19 repliesSuperseded
  3. v10 posting 1/28 patches 4 repliesSuperseded

Changes in v11 from the cover letter

- Move [PATCH v10 7/8] earlier (Eduard Zingerman)
- Fix the synchronization issue in [PATCH v10 2/8] (Eduard Zingerman, Alexei Starovoitov)

Patches in v11 All 8 applied

#Subject and filesSizeRepliesApplied
1/8bpf: refactor __bpf_list_del to take list node pointerkernel/bpf/helpers.c+15 -80 repliesApplied
2/8bpf: clear list node owner and unlink before dropkernel/bpf/helpers.c+19 -81 replyApplied
3/8bpf: allow non-owning list-node args via __nonown_allowedDocumentation/bpf/kfuncs.rst kernel/bpf/verifier.c+33 -21 replyApplied
4/8bpf: Introduce the bpf_list_del kfunc.kernel/bpf/helpers.c kernel/bpf/verifier.c+15 -11 replyApplied
5/8bpf: refactor __bpf_list_add to take insertion point via **prev_ptrkernel/bpf/helpers.c+26 -100 repliesApplied
6/8bpf: Add bpf_list_add to insert node after a given list nodekernel/bpf/helpers.c kernel/bpf/verifier.c+20 -31 replyApplied
7/8bpf: add bpf_list_is_first/last/empty kfuncskernel/bpf/helpers.c kernel/bpf/verifier.c+53 -20 repliesApplied
8/8selftests/bpf: Add test cases for bpf_list_del/add/is_first/is_last/emptytools/testing/selftests/bpf/progs/refcounted_kptr.c+421 -00 repliesApplied

Reviews trailers per patch

6 of 8 patches have a Reviewed-by or Acked-by.

PatchEduard ZingermanEmil Tsalapatis
1/8R-b
2/8
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v11 thread

Cover letter [PATCH bpf-next v11 0/8] bpf: Extend the bpf_list family of APIs

In BPF, a list can only be used to implement a stack structure. Due to an incomplete API set, only FIFO or LIFO operations are supported. The patches enhance the BPF list API, making it more list-like.

Five new kfuncs have been added:
bpf_list_del: remove a node from the list
bpf_list_add_impl: insert a node after a given list node
bpf_list_is_first: check if a node is the first in the list
bpf_list_is_last: check if a node is the last in the list
bpf_list_empty: check if the list is empty

And add test cases for the aforementioned kfuncs.

Changes in v11:
- Move [PATCH v10 7/8] earlier (Eduard Zingerman)
- Fix the synchronization issue in [PATCH v10 2/8] (Eduard Zingerman, Alexei Starovoitov)

Changes in v10:
- Remove the table-driven approach (Ihor Solodrai)
- Use the __nonown_allowed suffix for bpf_list_del/front/back
- Add test cases for __nonown_allowed

Changes in v9:
- Expand table-driven approach coverage (Emil Tsalapatis)
- Clear list node owner and unlink before drop (Emil Tsalapatis)
- Remove warnings caused by WARN_ON_ONCE() (Emil Tsalapatis)
- Introduce the __nonown_allowed suffix (Alexei Starovoitov)

Changes in v8:
- Use [patch v7 5/5] as the start of the patch series (Leon Hwang)
- Introduce double pointer prev_ptr in __bpf_list_del
(Kumar Kartikeya Dwivedi)
- Extract refactored __bpf_list_del/add into separate patches (Leon Hwang)
- Allow bpf_list_front/back result as the prev argument of bpf_list_add
- Split test cases (Leon Hwang)

Changes in v7:
- Replace bpf_list_node_is_edge with bpf_list_is_first/is_last
- Reimplement __bpf_list_del and __bpf_list_add (Kumar Kartikeya Dwivedi)
- Simplify test cases (Mykyta Yatsenko)

Changes in v6:
- Merge [patch v5 (2,4,6)/6] into [patch v6 4/5] (Leon Hwang)
- If list_head was 0-initialized, init it
- refactor kfunc checks to table-driven approach (Leon Hwang)

Changes in v5:
- Fix bpf_obj leak on bpf_list_add_impl error

Changes in v4:
- [patch v3 1/6] Revert to version v1 (Alexei Starovoitov)
- Change the parameters of bpf_list_add_impl to (head, new, prev, ...)

Changes in v3:
- Add a new lock_rec member to struct bpf_reference_state for lock holding detection.
- Add test cases to verify that the verifier correctly restricts calls to bpf_list_del when the spin_lock is not held.

Changes in v2:
- Remove the head parameter from bpf_list_del (Alexei Starovoitov)
- Add bpf_list_add/is_first/is_last/empty to API and test cases (Alexei Starovoitov)

Link to v10:
https://lore.kernel.org/all/[email protected]/

Link to v9:
https://lore.kernel.org/all/[email protected]/

Link to v8:
https://lore.kernel.org/all/[email protected]/

Link to v7:
https://lore.kernel.org/all/[email protected]/

Link to v6:
https://lore.kernel.org/all/[email protected]/

Link to v5:
https://lore.kernel.org/all/[email protected]/

Link to v4:
https://lore.kernel.org/all/[email protected]/

Link to v3:
https://lore.kernel.org/all/[email protected]/

Link to v2:
https://lore.kernel.org/all/[email protected]/

Link to v1:
https://lore.kernel.org/all/[email protected]/

Kaitao Cheng (8):
bpf: refactor __bpf_list_del to take list node pointer
bpf: clear list node owner and unlink before drop
bpf: allow non-owning list-node args via __nonown_allowed
bpf: Introduce the bpf_list_del kfunc.
bpf: refactor __bpf_list_add to take insertion point via **prev_ptr
bpf: Add bpf_list_add to insert node after a given list node
bpf: add bpf_list_is_first/last/empty kfuncs selftests/bpf: Add test cases for
bpf_list_del/add/is_first/is_last/empty

 Documentation/bpf/kfuncs.rst                  |  22 +-
 kernel/bpf/helpers.c                          | 147 ++++--
 kernel/bpf/verifier.c                         |  44 +-
 .../selftests/bpf/progs/refcounted_kptr.c     | 421 ++++++++++++++++++
 4 files changed, 601 insertions(+), 33 deletions(-)
Signature · 1 line
2.50.1 (Apple Git-155)