Skip to content

Proxy Execution fixes for v7.1-rc

John Stultz lkml llvm oe-kbuild-all 2 versions – Applied

Status from this message: The following commit has been merged into the sched/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 16 repliesApplied
  2. v12 patches 17 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2sched: proxy-exec: Close race causing workqueue work being delayedinclude/linux/sched.h kernel/sched/core.c+63 -1615 replies
2/2locking: mutex: Fix proxy-exec potentially deactivating tasks marked TASK_RUNNINGkernel/locking/mutex.c+1 -01 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchVineeth Pillai
1/2
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] Proxy Execution fixes for v7.1-rc

Hey All,
So in testing with the full Proxy Execution series,
Vineeth Pillai managed to trip some interesting bugs which initially looked to be KVM or RCU related[1], which he later diagnosed as Proxy Execution related and created a useful test driver to reproduce.

I found these same issues could be triggered with the upstream portions of Proxy Execution, so I wanted to send along these fixes for 7.1-rc

Again, a huge thanks to Vineeth for uncovering these issues that have evaded all my stress testing so far!

New in this version:
* Peter didn't like the change modifying task __state in schedule() and so I've reworked this to use an extra bit flag in the low bit of the blocked_on pointer. This does make the change a little larger then I'd like for a fix, but I think minimizing it further would create a bit of a mess.

Anyway, any feedback would be greatly appreciated!

Thanks
-john

[1]: https://lore.kernel.org/lkml/[email protected]/

Cc Vineeth Pillai <[email protected]>
Cc Sonam Sanju <[email protected]>
Cc Sean Christopherson <[email protected]>
Cc Kunwu Chan <[email protected]>
Cc Tejun Heo <[email protected]>
Cc Joel Fernandes <[email protected]>
Cc Qais Yousef <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Juri Lelli <[email protected]>
Cc Vincent Guittot <[email protected]>
Cc Dietmar Eggemann <[email protected]>
Cc Valentin Schneider <[email protected]>
Cc Steven Rostedt <[email protected]>
Cc Will Deacon <[email protected]>
Cc Waiman Long <[email protected]>
Cc Boqun Feng <[email protected]>
Cc "Paul E. McKenney" <[email protected]>
Cc Metin Kaya <[email protected]>
Cc Xuewen Yan <[email protected]>
Cc K Prateek Nayak <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Daniel Lezcano <[email protected]>
Cc Suleiman Souhlal <[email protected]>
Cc kuyo chang <[email protected]>

John Stultz (2):
sched: proxy-exec: Close race causing workqueue work being delayed
locking: mutex: Fix proxy-exec potentially deactivating tasks marked
TASK_RUNNING

 include/linux/sched.h  | 64 ++++++++++++++++++++++++++++++++++--------
 kernel/locking/mutex.c |  1 +
 kernel/sched/core.c    | 15 ++++++----
 3 files changed, 64 insertions(+), 16 deletions(-)
Signature · 1 line
2.54.0.545.g6539524ca2-goog