Skip to content

RFC net: guard SYS_RX_ETH_BUFFER with NET + required changes (ls1028a!) to make this happen

Quentin Schulz u-boot 2 versions – In review

Get series with b4
b4 am [email protected] change-id 20260428-sys_rx_eth_buffer-no-net-0ac1fd2004fa

Versions newest first

  1. v2 RFC Latest5 patches 1 replyIn review
  2. v1 RFC5 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- added Rb from Simon,
- reindented SYS_RX_ETH_BUFFER to start with a tab instead of spaces,
- added multiple-of-8 limitation for FSL_ENETC nin the help text,

- Link to v1: https://patch.msgid.link/[email protected]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ls1028a: only include drivers/net/fsl_enetc.h when driver is compiledboard/nxp/ls1028a/ls1028a.c+2 -00 replies
2/5arm: ls102xa: use platform data to check Ethernet interface is not SGMIIarch/arm/cpu/armv7/ls102xa/fdt.c+3 -40 replies
3/5net: tsec: make tsec_private a private structuredrivers/net/tsec.c include/tsec.h+17 -170 replies
4/5net: guard SYS_RX_ETH_BUFFER with NETinclude/net-common.h net/Kconfig+6 -20 replies
5/5net: SYS_RX_ETH_BUFFER defaults to 8 when CONFIG_FSL_ENETC=ynet/Kconfig+10 -70 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchSimon Glass
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH RFC next v2 0/5] net: guard SYS_RX_ETH_BUFFER with NET + required changes (ls1028a!) to make this happen

Adding ls1028a to the mail subject so that maybe it triggers some filter for maintainers/reviewers of those boards.

Follow-up to the NET->NET_LEGACY rename, where CONFIG_SYS_RX_ETH_BUFFER was discovered[1] to be in net/Kconfig but not guarded by NET.

Move a few things around such that we can guard this symbol by NET.

It'd be nice if someone could check patch 2 works as intended on the impacted platform(s), hence the RFC (and the ls1028a! in the mail subject).

CI passed here: https://source.denx.de/u-boot/contributors/qschulz/u-boot/-/pipelines/29934

[1] https://lore.kernel.org/u-boot/[email protected]/

---
Changes in v2:
- added Rb from Simon,
- reindented SYS_RX_ETH_BUFFER to start with a tab instead of spaces,
- added multiple-of-8 limitation for FSL_ENETC nin the help text,

- Link to v1: https://patch.msgid.link/[email protected]

---
Quentin Schulz (5):
ls1028a: only include drivers/net/fsl_enetc.h when driver is compiled
arm: ls102xa: use platform data to check Ethernet interface is not SGMII
net: tsec: make tsec_private a private structure
net: guard SYS_RX_ETH_BUFFER with NET
net: SYS_RX_ETH_BUFFER defaults to 8 when CONFIG_FSL_ENETC=y

 arch/arm/cpu/armv7/ls102xa/fdt.c |  7 +++----
 board/nxp/ls1028a/ls1028a.c      |  2 ++
 drivers/net/tsec.c               | 17 +++++++++++++++++
 include/net-common.h             |  4 ++++
 include/tsec.h                   | 17 -----------------
 net/Kconfig                      | 21 ++++++++++++---------
 6 files changed, 38 insertions(+), 30 deletions(-)

---
base-commit: 3cdd19089f1b1b7cd08530f33ff4708abcfd426c
change-id: 20260428-sys_rx_eth_buffer-no-net-0ac1fd2004fa

Best regards,

Signature · 1 line
Quentin Schulz <[email protected]>