Skip to content

Rework ice Tx checksum

Michal Swiatkowski intel-wired-lan netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ice: always do GCS if hardware supports itdrivers/net/ethernet/intel/ice/ice_lib.c drivers/net/ethernet/intel/ice/ice_txrx.c drivers/net/ethernet/intel/ice/ice_txrx.h+6 -11 reply
2/2ice: use NETIF_F_HW_CSUM instead of IP/IPV6drivers/net/ethernet/intel/ice/ice_main.c+1 -209 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPrzemek KitszelAleksandr LoktionovAlexander Nowlin
1/2R-b R-b T-b
2/2R-b R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH iwl-net v1 0/2] Rework ice Tx checksum

Hi,

Jakub find the problem with how ice handles Tx checksum offload [1].

The issue is that IP_CSUM/IPV6_CSUM should support only basic packet types. Kernel assumes that if there are extensions headers and there is no HW_CSUM software fallback should be applied. Here is a patch that introduced that [2].

However, software fallback can't be applied when TSO offload happens. That is the situation that this patchset is fixing.

When TSO is enabled and IP_CSUM/IPV6_CSUM is on, kernel is assuming hardware will be able to calculate the checksum, but later on the extension headers are checked and if there is no HW_CSUM the skb_bad_offload() is called.

Following the documentation ice driver is capable of HW_CSUM support, so switch from IP_CSUM/IPV6_CSUM to HW_CSUM. Other Intel drivers (even previous like i40e, ixgbe) also supports HW_CSUM.

The HW_CSUM was used to indicate that GCS (Intel name for checksumming offload using additional descriptor) is support, which is variation of HW_CSUM. Even without GCS th HW_CSUM is supported. First patch is switching to use custom Tx ring flags to allow HW_CSUM usage.

[1] https://lore.kernel.org/netdev/[email protected]/
[2] https://lore.kernel.org/all/5fbeecfc311ea182aa1d1c771725ab8b4cac515e.1729778144.git.benoit.monin@gmx.fr/

Michal Swiatkowski (2):
ice: always do GCS if hardware supports it
ice: use NETIF_F_HW_CSUM instead of IP/IPV6

 drivers/net/ethernet/intel/ice/ice_lib.c  |  4 ++++
 drivers/net/ethernet/intel/ice/ice_main.c | 21 +--------------------
 drivers/net/ethernet/intel/ice/ice_txrx.c |  2 +-
 drivers/net/ethernet/intel/ice/ice_txrx.h |  1 +
 4 files changed, 7 insertions(+), 21 deletions(-)
Signature · 1 line
2.49.0