drm/i915/dp_link: Refactor DP link capability logic part1
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest posting 2/228 patches 36 repliesIn review
- v2 posting 1/222 patches 25 repliesSuperseded
- v1108 patches 23 repliesSuperseded
Patches in v2 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/28 | drm/i915/dp: Rename intel_dp_link_config to intel_dp_link_config_entrydrivers/ drivers/ | +9 | 3 replies | |
| 2/28 | drm/i915/dp: Add struct intel_dp_link_configdrivers/ | +8 | 1 reply | |
| 3/28 | drm/i915/dp_link_caps: Introduce DP link capability moduledrivers/ drivers/ drivers/ +3 more | +55 | 1 reply | |
| 4/28 | drm/i915/dp_link_caps: Move common rate helpers to link capsdrivers/ drivers/ drivers/ +3 more | +39 | 1 reply | |
| 5/28 | drm/i915/dp_link_caps: Move forced link param helpers to link capsdrivers/ drivers/ drivers/ | +47 | 4 replies | |
| 6/28 | drm/i915/dp: Simplify querying of forced link parametersdrivers/ drivers/ | +12 | 1 reply | |
| 7/28 | drm/i915/dp_link_caps: Move forced and max link debugfs entries to link capsdrivers/ drivers/ drivers/ +1 more | +285 | 2 replies | |
| 8/28 | drm/i915/dp_link_training: Use helpers to get forced link paramsdrivers/ | +16 | 1 reply | |
| 9/28 | drm/i915/dp_link_caps: Move forced link params to link_capsdrivers/ drivers/ | +22 | 1 reply | |
| 10/28 | drm/i915/dp_link_caps: Move link config helpers to link capsdrivers/ drivers/ drivers/ +1 more | +107 | 1 reply | |
| 11/28 | drm/i915/dp_link_caps: Move link config tracking to link_capsdrivers/ drivers/ | +27 | 2 replies | |
| 12/28 | drm/i915/dp_link_caps: Rename helper updating the link configurationsdrivers/ drivers/ drivers/ | +3 | 1 reply | |
| 13/28 | drm/i915/dp: Factor out helper to get link rate capabilitiesdrivers/ | +22 | 1 reply | |
| 14/28 | drm/i915/dp_link_caps: Pass supported link rates to link caps updatedrivers/ drivers/ drivers/ | +33 | 1 reply | |
| 15/28 | drm/i915/dp_link_caps: Add helper to print all supported link ratesdrivers/ drivers/ drivers/ | +17 | 1 reply | |
| 16/28 | drm/i915/dp_link_caps: Add helper to get the number of supported link ratesdrivers/ drivers/ drivers/ | +8 | 1 reply | |
| 17/28 | drm/i915/dp_link_caps: Add helper to get common rate indexdrivers/ drivers/ drivers/ +1 more | +16 | 1 reply | |
| 18/28 | drm/i915/dp_link_caps: Move tracking of common rates to link_caps structdrivers/ drivers/ | +29 | 1 reply | |
| 19/28 | drm/i915/dp_link_caps: Track max common lane count in link_capsdrivers/ drivers/ drivers/ | +15 | 1 reply | |
| 20/28 | drm/i915/dp_link_caps: Use max common lane count from link_capsdrivers/ drivers/ drivers/ +3 more | +10 | 1 reply | |
| 21/28 | drm/i915/dp_link_caps: Add helpers to get max link limitsdrivers/ drivers/ drivers/ +1 more | +51 | 1 reply | |
| 22/28 | drm/i915/dp_link_caps: Add helpers to set max link limitsdrivers/ drivers/ drivers/ | +44 | 1 reply | |
| 23/28 | drm/i915/dp_link_caps: Add helper to reset max link limitsdrivers/ drivers/ | +23 | 1 reply | |
| 24/28 | drm/i915/dp_link_caps: Add helper to reset link_caps statedrivers/ drivers/ drivers/ | +20 | 1 reply | |
| 25/28 | drm/i915/dp_link_caps: Move max link limits to link_capsdrivers/ drivers/ | +13 | 1 reply | |
| 26/28 | drm/i915/dp_link_caps: Pass link_caps to static functionsdrivers/ | +19 | 1 reply | |
| 27/28 | drm/i915/dp_link_caps: Pass link_caps to config update/lookup helpersdrivers/ drivers/ drivers/ +1 more | +16 | 1 reply | |
| 28/28 | drm/i915/dp_link_caps: Pass link_caps to common rate helpersdrivers/ drivers/ drivers/ +2 more | +25 | 1 reply |
Reviews trailers per patch
All 28 patches have a Reviewed-by or Acked-by.
| Patch | Mika Kahola | Michał Grzelak | Nemesa Garg | Luca Coelho |
|---|---|---|---|---|
| 1/28 | R-b | R-b | ||
| 2/28 | R-b | |||
| 3/28 | R-b | |||
| 4/28 | R-b | |||
| 5/28 | R-b | R-b | ||
| 6/28 | R-b | |||
| 7/28 | R-b R-b | |||
| 8/28 | R-b | |||
| 9/28 | R-b | |||
| 10/28 | R-b | |||
| 11/28 | R-b | R-b | ||
| 12/28 | R-b | |||
| 13/28 | R-b | |||
| 14/28 | R-b | |||
| 15/28 | R-b | |||
| 16/28 | R-b | |||
| 17/28 | R-b | |||
| 18/28 | R-b | |||
| 19/28 | R-b | |||
| 20/28 | R-b | |||
| 21/28 | R-b | |||
| 22/28 | R-b | |||
| 23/28 | R-b | |||
| 24/28 | R-b | |||
| 25/28 | R-b | |||
| 26/28 | R-b | |||
| 27/28 | R-b | |||
| 28/28 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v2 00/28] drm/i915/dp_link: Refactor DP link capability logic part1
This is v2 of the second part of [1] refactoring the DP link capability logic in patches 27-57 of [1]. The first part of [1] was merged, see [2]. For the rationale of this patchset, please refer to the link capability parts in the cover letter of [1].
This v2 version has the following changes:
- Address the review comments from Jani:
- Remove unneeded function documentation.
- Add a helper to debug print the link rates tracked by link_caps instead of exposing the rates.
- Simplify tracking of link capability changes as suggested by Ville, removing the need to track changes or adjust the maximum link parameter limits set by the fallback logic. This is possible, since the limits are reset now (after patchset [3]) whenever any link parameter changes. This resulted in dropping patches 46, 48, 51 from patchset [1].
[1] https://lore.kernel.org/all/[email protected]
[2] https://lore.kernel.org/all/[email protected]
[3] https://lore.kernel.org/all/[email protected]
Imre Deak (28):
drm/i915/dp: Rename intel_dp_link_config to intel_dp_link_config_entry drm/i915/dp: Add struct intel_dp_link_config drm/i915/dp_link_caps: Introduce DP link capability module drm/i915/dp_link_caps: Move common rate helpers to link caps drm/i915/dp_link_caps: Move forced link param helpers to link caps drm/i915/dp: Simplify querying of forced link parameters drm/i915/dp_link_caps: Move forced and max link debugfs entries to
link caps
drm/i915/dp_link_training: Use helpers to get forced link params drm/i915/dp_link_caps: Move forced link params to link_caps drm/i915/dp_link_caps: Move link config helpers to link caps drm/i915/dp_link_caps: Move link config tracking to link_caps drm/i915/dp_link_caps: Rename helper updating the link configurations drm/i915/dp: Factor out helper to get link rate capabilities drm/i915/dp_link_caps: Pass supported link rates to link caps update drm/i915/dp_link_caps: Add helper to print all supported link rates drm/i915/dp_link_caps: Add helper to get the number of supported link
rates
drm/i915/dp_link_caps: Add helper to get common rate index drm/i915/dp_link_caps: Move tracking of common rates to link_caps
struct
drm/i915/dp_link_caps: Track max common lane count in link_caps drm/i915/dp_link_caps: Use max common lane count from link_caps drm/i915/dp_link_caps: Add helpers to get max link limits drm/i915/dp_link_caps: Add helpers to set max link limits drm/i915/dp_link_caps: Add helper to reset max link limits drm/i915/dp_link_caps: Add helper to reset link_caps state drm/i915/dp_link_caps: Move max link limits to link_caps drm/i915/dp_link_caps: Pass link_caps to static functions drm/i915/dp_link_caps: Pass link_caps to config update/lookup helpers drm/i915/dp_link_caps: Pass link_caps to common rate helpers
drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/display/intel_display_debugfs.c | 2 + .../drm/i915/display/intel_display_types.h | 32 +- drivers/gpu/drm/i915/display/intel_dp.c | 272 ++----- drivers/gpu/drm/i915/display/intel_dp.h | 6 +- .../gpu/drm/i915/display/intel_dp_link_caps.c | 675 ++++++++++++++++++ .../gpu/drm/i915/display/intel_dp_link_caps.h | 47 ++ .../drm/i915/display/intel_dp_link_training.c | 320 +-------- drivers/gpu/drm/i915/display/intel_dp_test.c | 7 +- .../gpu/drm/i915/display/intel_dp_tunnel.c | 6 +- drivers/gpu/drm/xe/Makefile | 1 + 11 files changed, 854 insertions(+), 515 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dp_link_caps.c create mode 100644 drivers/gpu/drm/i915/display/intel_dp_link_caps.h
Signature · 1 line
2.49.1