Skip to content

dpll: add pin operational state

Ivan Vecera linux-doc lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesApplied 2/2

Patches in v1 All 2 applied

#Subject and filesSizeRepliesApplied
1/2dpll: add pin operational stateDocumentation/driver-api/dpll.rst Documentation/netlink/specs/dpll.yaml drivers/dpll/dpll_netlink.c +4 more+113 -173 repliesApplied
2/2dpll: zl3073x: implement pin operational state reportingdrivers/dpll/zl3073x/dpll.c drivers/dpll/zl3073x/regs.h+79 -382 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJiri PirkoVadim FedorenkoPetr Oros
1/2R-b R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH net-next 0/2] dpll: add pin operational state

Add pin operational state (operstate) to the DPLL subsystem to separate administrative intent from actual hardware status.

Currently pin-state mixes what the user requested (connected, selectable, disconnected) with what the hardware is actually doing. This makes it difficult to diagnose situations where a user sets a pin as selectable or connected but the hardware cannot use it due to signal issues.

The new operstate attribute is reported inside the pin-parent-device nest alongside the existing state and is read-only. Defined values:

- active: pin is qualified and actively used by the DPLL
- standby: pin is qualified but not actively used by the DPLL
- no-signal: pin does not have a valid signal
- qual-failed: pin signal failed qualification checks

Patch 1 adds the operstate enum, netlink attribute and the operstate_on_dpll_get callback to the DPLL subsystem. It also updates Documentation/driver-api/dpll.rst to describe the separation between admin state and operational state.

Patch 2 implements the callback for ZL3073x input pins using the reference monitor status register. It also refactors the existing state_on_dpll_get to return purely administrative state and switches periodic monitoring to track operstate changes.

Ivan Vecera (2):
dpll: add pin operational state
dpll: zl3073x: implement pin operational state reporting

 Documentation/driver-api/dpll.rst     |  38 +++++----
 Documentation/netlink/specs/dpll.yaml |  31 ++++++++
 drivers/dpll/dpll_netlink.c           |  27 +++++++
 drivers/dpll/dpll_nl.c                |   3 +-
 drivers/dpll/dpll_nl.h                |   2 +-
 drivers/dpll/zl3073x/dpll.c           | 108 +++++++++++++++++---------
 drivers/dpll/zl3073x/regs.h           |   9 ++-
 include/linux/dpll.h                  |   6 ++
 include/uapi/linux/dpll.h             |  23 ++++++
 9 files changed, 192 insertions(+), 55 deletions(-)

base-commit: 1f5ffc672165ff851063a5fd044b727ab2517ae3

Signature · 1 line
2.53.0