Skip to content

RFC net: napi: Fix timer arming during busy poll timeout

Dragos Tatulea lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: napi: Fix interrupts permanently disabled during busy pollnet/core/dev.c+17 -911 replies
2/2net: napi: Skip poll when arming GRO timer in busy pollnet/core/dev.c+30 -313 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH net-next 0/2] net: napi: Fix timer arming during busy poll timeout

Under certain conditions a queue can be left out with interrupts disabled and with the napi re-scheduling timer permanently stopped. This behaviour is triggered by the napi busy poll path when gro-flush-timeout and defer-hard-irq are set.

The first patch is a fix and has a more detailed description of how the issue can occur.

The second patch represents an improvement which needs additional review (hence the RFC).

The strategy for the non-RFC version is to send the first patch as a fix to net and then send the improvement to net-next because of the behavioral change (skipping the poll).

Is this the right way to go or should the 2 patches be squashed into a fix for net?

[1] https://lore.kernel.org/netdev/[email protected]/

Dragos Tatulea (1):
net: napi: Fix interrupts permanently disabled during busy poll

Martin Karsten (1):
net: napi: Skip poll when arming GRO timer in busy poll

 net/core/dev.c | 49 ++++++++++++++++++++++++++++---------------------
 1 file changed, 28 insertions(+), 21 deletions(-)
Signature · 1 line
2.43.0