Skip to content

Minor cleanups: eliminate redundant code in QOM, block-backend and vl.c

Bin Guo qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3qom/object: merge double hash table traversal in object_property_del_childqom/object.c+0 -73 replies
2/3block/block-backend: delegate blk_co_preadv to blk_co_preadv_partblock/block-backend.c+1 -72 replies
3/3system/vl.c: inline qemu_opts_parse_noisily() result checkssystem/vl.c+15 -223 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéRichard HendersonKevin Wolf
1/3R-b
2/3R-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/3] Minor cleanups: eliminate redundant code in QOM, block-backend and vl.c

This series contains three independent cleanups that remove redundant code and improve consistency across different subsystems.

Patch 1 merges a double hash-table traversal in object_property_del_child() into a single pass, halving the number of hash table operations in the common case.

Patch 2 makes blk_co_preadv() a one-liner wrapper around blk_co_preadv_part(), matching the existing pattern already used by the write side (blk_co_pwritev / blk_co_pwritev_part).

Patch 3 inlines qemu_opts_parse_noisily() return-value checks directly into if-conditions for options that do not use the returned pointer, matching the style already used by QEMU_OPTION_action.

All three patches are independent and can be applied in any order.

Bin Guo (3):
qom/object: merge double hash table traversal in
object_property_del_child
block/block-backend: delegate blk_co_preadv to blk_co_preadv_part system/vl.c: inline qemu_opts_parse_noisily() result checks

 block/block-backend.c |  8 +-------
 qom/object.c          |  7 -------
 system/vl.c           | 37 +++++++++++++++----------------------
 3 files changed, 16 insertions(+), 36 deletions(-)
Signature · 1 line
2.50.1 (Apple Git-155)