Skip to content

fix and improve for Hi846

Pengyu Luo imx linux-arm-kernel linux-devicetree linux-media lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest5 patches 3 repliesIn review
  2. v55 patches 3 repliesSuperseded
  3. v45 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v35 patches2 repliesSuperseded
v24 patches2 repliesSuperseded
v12 patches4 repliesSuperseded

Changes in v6 from the cover letter

- Add link freq ctrl back (Sakari)
- Use v4l2_link_freq_to_bitmap() to get matched link freqs (Sakari)
- Move clk_get() before than hi846_parse_dt(), since we use clock in hi846_parse_dt()
- Add link freq check in filter for v4l2_find_nearest_size_conditional().
- Link to v5: https://lore.kernel.org/linux-media/[email protected]

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5media: hi846: Fix hi846_write_reg_16 handlingdrivers/media/i2c/hi846.c+2 -00 replies
2/5media: hi846: Fix link frequency handlingdrivers/media/i2c/hi846.c+94 -573 replies
3/5media: hi846: Fix modes handling for different lane casesdrivers/media/i2c/hi846.c+39 -240 replies
4/5media: hi846: Add 6MP and 8MP modes supportdrivers/media/i2c/hi846.c+153 -10 replies
5/5arm64: dts: imx8mq-librem5: Correct link frequency listarch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH v6 0/5] fix and improve for Hi846

This series fixes errors blocking Hi846 driver function, fixes link frequency and supports 6MP and 8MP modes on Hi846.

---
Changes in v6:
- Add link freq ctrl back (Sakari)
- Use v4l2_link_freq_to_bitmap() to get matched link freqs (Sakari)
- Move clk_get() before than hi846_parse_dt(), since we use clock in hi846_parse_dt()
- Add link freq check in filter for v4l2_find_nearest_size_conditional().
- Link to v5: https://lore.kernel.org/linux-media/[email protected]

Changes in v5:
- Use separated fields instead of raw register values for PLL cfg (Sakari)
- Use mul_u64_u32_div() to avoid loss of pricision and u64/u32 issues (Sakari)
- Use v4l2_find_nearest_size_conditional() to filter for different lane cases. (Sakari)
- Drop line break (Sakari)
- Rename post_div to mipi_clk_div
- Correct div1 number from 1 to 2
- Link to v4: https://lore.kernel.org/linux-media/[email protected]

Changes in v4:
- Correct default lane cfg in commit for 'fix link frequency handling'
- Fix messed header (the Media CI robot)
- Move constant to the right side when comparsion (the Media CI robot)
- Link to v3: https://lore.kernel.org/linux-media/[email protected]

Changes in v3:
- Fix modes handling for different lane cases (Sebastian)
- Fix header missing (the Media CI robot)
- Link to v2: https://lore.kernel.org/linux-media/[email protected]

Changes in v2:
- Remove uncessary else (Sakari)
- Fix link frequency (Sakari)
- Correct link frequency for DT
- Link to v1: https://lore.kernel.org/linux-media/[email protected]

Pengyu Luo (5):
media: hi846: Fix hi846_write_reg_16 handling
media: hi846: Fix link frequency handling
media: hi846: Fix modes handling for different lane cases
media: hi846: Add 6MP and 8MP modes support
arm64: dts: imx8mq-librem5: Correct link frequency list

 .../boot/dts/freescale/imx8mq-librem5.dtsi    |   2 +-
 drivers/media/i2c/hi846.c                     | 370 ++++++++++++++----
 2 files changed, 289 insertions(+), 83 deletions(-)
Signature · 1 line
2.55.0